Skip to content

[rtsan][NFC] Refactor to scoped bypasser for __rtsan::Context #111438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2024
Merged

[rtsan][NFC] Refactor to scoped bypasser for __rtsan::Context #111438

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b825c97
[rtsan][NFC] Refactor to scoped bypasser for Context
cjappl Oct 7, 2024
a58aa86
[PR] fmayer - delete other ctors, assignment ops
cjappl Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions compiler-rt/lib/rtsan/rtsan_assertions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@ template <typename OnViolationAction>
void ExpectNotRealtime(Context &context, OnViolationAction &&OnViolation) {
CHECK(__rtsan_is_initialized());
if (context.InRealtimeContext() && !context.IsBypassed()) {
context.BypassPush();
ScopedBypass sb{context};
OnViolation();
context.BypassPop();
}
}

Expand Down
12 changes: 12 additions & 0 deletions compiler-rt/lib/rtsan/rtsan_context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,17 @@ class Context {
int bypass_depth_{0};
};

class ScopedBypass {
public:
[[nodiscard]] explicit ScopedBypass(Context &context) : context_(context) {
context_.BypassPush();
}

~ScopedBypass() { context_.BypassPop(); }

private:
Context &context_;
};

Context &GetContextForThisThread();
} // namespace __rtsan
Loading