Skip to content

[Hexagon] Mark instructions as part of the frame setup to fix test sugared-constants.ll #111795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024
Merged

[Hexagon] Mark instructions as part of the frame setup to fix test sugared-constants.ll #111795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions llvm/lib/Target/Hexagon/HexagonFrameLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,22 +906,25 @@ void HexagonFrameLowering::insertAllocframe(MachineBasicBlock &MBB,
if (NumBytes >= ALLOCFRAME_MAX) {
// Emit allocframe(#0).
BuildMI(MBB, InsertPt, dl, HII.get(Hexagon::S2_allocframe))
.addDef(SP)
.addReg(SP)
.addImm(0)
.addMemOperand(MMO);
.addDef(SP)
.addReg(SP)
.addImm(0)
.addMemOperand(MMO)
.setMIFlag(MachineInstr::FrameSetup);

// Subtract the size from the stack pointer.
Register SP = HRI.getStackRegister();
BuildMI(MBB, InsertPt, dl, HII.get(Hexagon::A2_addi), SP)
.addReg(SP)
.addImm(-int(NumBytes));
.addReg(SP)
.addImm(-int(NumBytes))
.setMIFlag(MachineInstr::FrameSetup);
} else {
BuildMI(MBB, InsertPt, dl, HII.get(Hexagon::S2_allocframe))
.addDef(SP)
.addReg(SP)
.addImm(NumBytes)
.addMemOperand(MMO);
.addDef(SP)
.addReg(SP)
.addImm(NumBytes)
.addMemOperand(MMO)
.setMIFlag(MachineInstr::FrameSetup);
}
}

Expand Down
4 changes: 0 additions & 4 deletions llvm/test/DebugInfo/Generic/sugared-constants.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
; xfail this test on hexagon because upstream llc is not emitting the
; correct DWARF info. Downstream llc is.
; XFAIL: target=hexagon-{{.*}}

; RUN: %llc_dwarf -O0 -filetype=obj %s -o - | llvm-dwarfdump -v -debug-info - | FileCheck %s
; Use correct signedness when emitting constants of derived (sugared) types.

Expand Down
Loading