-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[rtsan] Introduce function-name-matches suppression #112108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b5dc1aa
[rtsan] Introduce blocking-fn-name and intercepted-fn-name suppressions
cjappl 95b54ae
[PR] self - add CAS loop in test so empty BlockFunc doesn't get remov…
cjappl 2c98c51
[PR] - move to function-name-is
cjappl 17d9ce9
function-name-matches
cjappl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| // RUN: %clangxx -fsanitize=realtime %s -o %t | ||
| // RUN: %env_rtsan_opts=halt_on_error=false %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-NOSUPPRESSIONS | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added this check here to make sure that these would actually cause errors before suppressing them |
||
| // RUN: %env_rtsan_opts=suppressions='%s.supp' not %run %t 2>&1 | FileCheck %s | ||
| // UNSUPPORTED: ios | ||
|
|
||
|
|
@@ -8,8 +9,11 @@ | |
| #include <stdlib.h> | ||
| #include <unistd.h> | ||
|
|
||
| #include <atomic> | ||
| #include <vector> | ||
|
|
||
| std::atomic<int> cas_atomic{0}; | ||
|
|
||
| void *MallocViolation() { return malloc(10); } | ||
|
|
||
| void VectorViolations() { | ||
|
|
@@ -22,13 +26,18 @@ void VectorViolations() { | |
| v.reserve(10); | ||
| } | ||
|
|
||
| void BlockFunc() [[clang::blocking]] { usleep(1); } | ||
| void BlockFunc() [[clang::blocking]] { | ||
| int expected = 0; | ||
| while (!cas_atomic.compare_exchange_weak(expected, 1)) { | ||
| expected = cas_atomic.load(); | ||
| } | ||
| } | ||
|
|
||
| void *process() [[clang::nonblocking]] { | ||
| void *ptr = MallocViolation(); | ||
| VectorViolations(); | ||
| BlockFunc(); | ||
| free(ptr); | ||
| void *ptr = MallocViolation(); // Suppressed call-stack-contains | ||
| VectorViolations(); // Suppressed call-stack-contains with regex | ||
| BlockFunc(); // Suppressed function-name-matches | ||
| free(ptr); // Suppressed function-name-matches | ||
|
|
||
| // This is the one that should abort the program | ||
| // Everything else is suppressed | ||
|
|
@@ -51,3 +60,9 @@ int main() { | |
| // CHECK-NOT: vector | ||
| // CHECK-NOT: free | ||
| // CHECK-NOT: BlockFunc | ||
|
|
||
| // CHECK-NOSUPPRESSIONS: malloc | ||
| // CHECK-NOSUPPRESSIONS: vector | ||
| // CHECK-NOSUPPRESSIONS: free | ||
| // CHECK-NOSUPPRESSIONS: BlockFunc | ||
| // CHECK-NOSUPPRESSIONS: usleep | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| call-stack-contains:MallocViolation | ||
| call-stack-contains:std::*vector | ||
| call-stack-contains:free | ||
| call-stack-contains:BlockFunc | ||
|
|
||
| function-name-matches:free | ||
| function-name-matches:Block* |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.