[NFC][Intrumentation] Don't brake long RUN: lines #112281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
Contributor
|
I generally prefer the wrapped lines but if you feel strongly go ahead. |
Collaborator
Author
Yes, I'd like to do so very much. Bug if it's needed there is wrap on/off in most editors. I need to think hard to difference in the first one, and it's obvious in the second.
|
Contributor
|
Wouldn't that make one per line better for diffing? That's what I generally do for long command lines to read / diff them. |
fmayer
approved these changes
Oct 15, 2024
Contributor
fmayer
left a comment
fmayer
left a comment
There was a problem hiding this comment.
Sure, I don't feel strongly.
vitalybuka
deleted the
users/vitalybuka/spr/nfcintrumentation-dont-brake-long-run-lines
branch
DanielCChen
pushed a commit
to DanielCChen/llvm-project
that referenced
this pull request
Oct 16, 2024
I find multiline 'RUN:' statements hard to read. ` *\\\n; RUN: *` -> ` ` for ./llvm/test/Instrumentation/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find multiline 'RUN:' statements hard to read.
*\\\n; RUN: *->