-
Notifications
You must be signed in to change notification settings - Fork 15.4k
release/19.x: [NFC] fix build failure (#100993) #112551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@arsenm What do you think about merging this PR to the release branch? |
|
@llvm/pr-subscribers-llvm-analysis Author: None (llvmbot) ChangesBackport 40b4fd7 Requested by: @mgorny Full diff: https://github.com/llvm/llvm-project/pull/112551.diff 1 Files Affected:
diff --git a/llvm/lib/Analysis/ConstantFolding.cpp b/llvm/lib/Analysis/ConstantFolding.cpp
index df75745645e049..ff30fece5fce93 100644
--- a/llvm/lib/Analysis/ConstantFolding.cpp
+++ b/llvm/lib/Analysis/ConstantFolding.cpp
@@ -1784,8 +1784,8 @@ Constant *ConstantFoldFP(double (*NativeFP)(double), const APFloat &V,
}
#if defined(HAS_IEE754_FLOAT128) && defined(HAS_LOGF128)
-Constant *ConstantFoldFP128(long double (*NativeFP)(long double),
- const APFloat &V, Type *Ty) {
+Constant *ConstantFoldFP128(float128 (*NativeFP)(float128), const APFloat &V,
+ Type *Ty) {
llvm_fenv_clearexcept();
float128 Result = NativeFP(V.convertToQuad());
if (llvm_fenv_testexcept()) {
|
arsenm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this isn't an ABI break in any cases where this builds?
The function is not declared in any header file, in fact it sits in an (unfortunately relatively large) anonymous namespace (starting here at line 1732). So it should be fine. |
|
@arsenm, does the above comment answer your concerns? If so, could you please approve it before the next release. |
Fix the build failure caused by llvm#94944 Fixes llvm#100296 (cherry picked from commit 40b4fd7)
|
@mgorny (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. |
Backport 40b4fd7
Requested by: @mgorny