Skip to content

Conversation

@llvmbot
Copy link
Member

@llvmbot llvmbot commented Oct 16, 2024

Backport 40b4fd7

Requested by: @mgorny

@llvmbot llvmbot added this to the LLVM 19.X Release milestone Oct 16, 2024
@llvmbot
Copy link
Member Author

llvmbot commented Oct 16, 2024

@arsenm What do you think about merging this PR to the release branch?

@llvmbot llvmbot requested a review from arsenm October 16, 2024 14:14
@llvmbot llvmbot added the llvm:analysis Includes value tracking, cost tables and constant folding label Oct 16, 2024
@llvmbot
Copy link
Member Author

llvmbot commented Oct 16, 2024

@llvm/pr-subscribers-llvm-analysis

Author: None (llvmbot)

Changes

Backport 40b4fd7

Requested by: @mgorny


Full diff: https://github.com/llvm/llvm-project/pull/112551.diff

1 Files Affected:

  • (modified) llvm/lib/Analysis/ConstantFolding.cpp (+2-2)
diff --git a/llvm/lib/Analysis/ConstantFolding.cpp b/llvm/lib/Analysis/ConstantFolding.cpp
index df75745645e049..ff30fece5fce93 100644
--- a/llvm/lib/Analysis/ConstantFolding.cpp
+++ b/llvm/lib/Analysis/ConstantFolding.cpp
@@ -1784,8 +1784,8 @@ Constant *ConstantFoldFP(double (*NativeFP)(double), const APFloat &V,
 }
 
 #if defined(HAS_IEE754_FLOAT128) && defined(HAS_LOGF128)
-Constant *ConstantFoldFP128(long double (*NativeFP)(long double),
-                            const APFloat &V, Type *Ty) {
+Constant *ConstantFoldFP128(float128 (*NativeFP)(float128), const APFloat &V,
+                            Type *Ty) {
   llvm_fenv_clearexcept();
   float128 Result = NativeFP(V.convertToQuad());
   if (llvm_fenv_testexcept()) {

Copy link
Contributor

@arsenm arsenm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this isn't an ABI break in any cases where this builds?

@mgorny
Copy link
Member

mgorny commented Oct 16, 2024

CC @chenzheng1030 @aaronpuchert

@aaronpuchert
Copy link
Member

I'm assuming this isn't an ABI break in any cases where this builds?

The function is not declared in any header file, in fact it sits in an (unfortunately relatively large) anonymous namespace (starting here at line 1732). So it should be fine.

@mgorny mgorny requested a review from arsenm October 26, 2024 16:50
@mgorny
Copy link
Member

mgorny commented Oct 26, 2024

@arsenm, does the above comment answer your concerns? If so, could you please approve it before the next release.

Fix the build failure caused by
llvm#94944

Fixes llvm#100296

(cherry picked from commit 40b4fd7)
@tru tru merged commit 6ee4908 into llvm:release/19.x Oct 29, 2024
7 of 9 checks passed
@github-actions
Copy link

@mgorny (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

bedroge added a commit to bedroge/easybuild-easyconfigs that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

llvm:analysis Includes value tracking, cost tables and constant folding

Projects

Development

Successfully merging this pull request may close these issues.

5 participants