Skip to content

[WebAssembly] Add atan2 to RuntimeLibcallSignatureTable #112613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2024
Merged

[WebAssembly] Add atan2 to RuntimeLibcallSignatureTable #112613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51813c8
Add atan2 to wasm RuntimeLibcallSignatureTable
tex3d Oct 15, 2024
f00b30a
Update test checks with update_llc_test_checks.py
tex3d Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions llvm/lib/Target/WebAssembly/WebAssemblyRuntimeLibcallSignatures.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,9 @@ struct RuntimeLibcallSignatureTable {
Table[RTLIB::ATAN_F32] = f32_func_f32;
Table[RTLIB::ATAN_F64] = f64_func_f64;
Table[RTLIB::ATAN_F128] = i64_i64_func_i64_i64;
Table[RTLIB::ATAN2_F32] = f32_func_f32_f32;
Table[RTLIB::ATAN2_F64] = f64_func_f64_f64;
Table[RTLIB::ATAN2_F128] = i64_i64_func_i64_i64_i64_i64;
Table[RTLIB::SINH_F32] = f32_func_f32;
Table[RTLIB::SINH_F64] = f64_func_f64;
Table[RTLIB::SINH_F128] = i64_i64_func_i64_i64;
Expand Down
316 changes: 170 additions & 146 deletions llvm/test/CodeGen/WebAssembly/libcalls-trig.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,11 @@ declare fp128 @llvm.cos.f128(fp128)
declare fp128 @llvm.tan.f128(fp128)
declare fp128 @llvm.asin.f128(fp128)
declare fp128 @llvm.acos.f128(fp128)
declare fp128 @llvm.atan.f128.i32(fp128)
declare fp128 @llvm.atan.f128(fp128)
declare fp128 @llvm.sinh.f128(fp128)
declare fp128 @llvm.cosh.f128(fp128)
declare fp128 @llvm.tanh.f128(fp128)
declare fp128 @llvm.atan2.f128(fp128, fp128)

declare double @llvm.sin.f64(double)
declare double @llvm.cos.f64(double)
Expand All @@ -24,6 +25,7 @@ declare double @llvm.atan.f64(double)
declare double @llvm.sinh.f64(double)
declare double @llvm.cosh.f64(double)
declare double @llvm.tanh.f64(double)
declare double @llvm.atan2.f64(double, double)

declare float @llvm.sin.f32(float)
declare float @llvm.cos.f32(float)
Expand All @@ -34,6 +36,7 @@ declare float @llvm.atan.f32(float)
declare float @llvm.sinh.f32(float)
declare float @llvm.cosh.f32(float)
declare float @llvm.tanh.f32(float)
declare float @llvm.atan2.f32(float, float)


define fp128 @fp128libcalls(fp128 %x) {
Expand All @@ -42,154 +45,171 @@ define fp128 @fp128libcalls(fp128 %x) {
; CHECK: .functype fp128libcalls (i32, i64, i64) -> ()
; CHECK-NEXT: .local i32
; CHECK-NEXT: # %bb.0:
; CHECK-NEXT: global.get $push28=, __stack_pointer
; CHECK-NEXT: i32.const $push29=, 144
; CHECK-NEXT: i32.sub $push73=, $pop28, $pop29
; CHECK-NEXT: local.tee $push72=, 3, $pop73
; CHECK-NEXT: global.set __stack_pointer, $pop72
; CHECK-NEXT: local.get $push74=, 3
; CHECK-NEXT: i32.const $push62=, 128
; CHECK-NEXT: i32.add $push63=, $pop74, $pop62
; CHECK-NEXT: local.get $push76=, 1
; CHECK-NEXT: local.get $push75=, 2
; CHECK-NEXT: call sinl, $pop63, $pop76, $pop75
; CHECK-NEXT: local.get $push77=, 3
; CHECK-NEXT: i32.const $push58=, 112
; CHECK-NEXT: i32.add $push59=, $pop77, $pop58
; CHECK-NEXT: local.get $push78=, 3
; CHECK-NEXT: i64.load $push3=, 128($pop78)
; CHECK-NEXT: local.get $push79=, 3
; CHECK-NEXT: i32.const $push60=, 128
; CHECK-NEXT: i32.add $push61=, $pop79, $pop60
; CHECK-NEXT: i32.const $push0=, 8
; CHECK-NEXT: i32.add $push1=, $pop61, $pop0
; CHECK-NEXT: i64.load $push2=, 0($pop1)
; CHECK-NEXT: call cosl, $pop59, $pop3, $pop2
; CHECK-NEXT: local.get $push80=, 3
; CHECK-NEXT: i32.const $push54=, 96
; CHECK-NEXT: i32.add $push55=, $pop80, $pop54
; CHECK-NEXT: local.get $push81=, 3
; CHECK-NEXT: i64.load $push6=, 112($pop81)
; CHECK-NEXT: local.get $push82=, 3
; CHECK-NEXT: i32.const $push56=, 112
; CHECK-NEXT: i32.add $push57=, $pop82, $pop56
; CHECK-NEXT: i32.const $push71=, 8
; CHECK-NEXT: i32.add $push4=, $pop57, $pop71
; CHECK-NEXT: i64.load $push5=, 0($pop4)
; CHECK-NEXT: call tanl, $pop55, $pop6, $pop5
; CHECK-NEXT: local.get $push83=, 3
; CHECK-NEXT: i32.const $push50=, 80
; CHECK-NEXT: i32.add $push51=, $pop83, $pop50
; CHECK-NEXT: local.get $push84=, 3
; CHECK-NEXT: i64.load $push9=, 96($pop84)
; CHECK-NEXT: local.get $push85=, 3
; CHECK-NEXT: i32.const $push52=, 96
; CHECK-NEXT: i32.add $push53=, $pop85, $pop52
; CHECK-NEXT: i32.const $push70=, 8
; CHECK-NEXT: i32.add $push7=, $pop53, $pop70
; CHECK-NEXT: i64.load $push8=, 0($pop7)
; CHECK-NEXT: call asinl, $pop51, $pop9, $pop8
; CHECK-NEXT: local.get $push86=, 3
; CHECK-NEXT: i32.const $push46=, 64
; CHECK-NEXT: i32.add $push47=, $pop86, $pop46
; CHECK-NEXT: local.get $push87=, 3
; CHECK-NEXT: i64.load $push12=, 80($pop87)
; CHECK-NEXT: local.get $push88=, 3
; CHECK-NEXT: i32.const $push48=, 80
; CHECK-NEXT: i32.add $push49=, $pop88, $pop48
; CHECK-NEXT: i32.const $push69=, 8
; CHECK-NEXT: i32.add $push10=, $pop49, $pop69
; CHECK-NEXT: i64.load $push11=, 0($pop10)
; CHECK-NEXT: call acosl, $pop47, $pop12, $pop11
; CHECK-NEXT: local.get $push89=, 3
; CHECK-NEXT: i32.const $push42=, 48
; CHECK-NEXT: i32.add $push43=, $pop89, $pop42
; CHECK-NEXT: local.get $push90=, 3
; CHECK-NEXT: i64.load $push15=, 64($pop90)
; CHECK-NEXT: local.get $push91=, 3
; CHECK-NEXT: i32.const $push44=, 64
; CHECK-NEXT: i32.add $push45=, $pop91, $pop44
; CHECK-NEXT: i32.const $push68=, 8
; CHECK-NEXT: i32.add $push13=, $pop45, $pop68
; CHECK-NEXT: i64.load $push14=, 0($pop13)
; CHECK-NEXT: call atanl, $pop43, $pop15, $pop14
; CHECK-NEXT: local.get $push92=, 3
; CHECK-NEXT: i32.const $push38=, 32
; CHECK-NEXT: i32.add $push39=, $pop92, $pop38
; CHECK-NEXT: local.get $push93=, 3
; CHECK-NEXT: i64.load $push18=, 48($pop93)
; CHECK-NEXT: local.get $push94=, 3
; CHECK-NEXT: i32.const $push40=, 48
; CHECK-NEXT: i32.add $push41=, $pop94, $pop40
; CHECK-NEXT: i32.const $push67=, 8
; CHECK-NEXT: i32.add $push16=, $pop41, $pop67
; CHECK-NEXT: i64.load $push17=, 0($pop16)
; CHECK-NEXT: call sinhl, $pop39, $pop18, $pop17
; CHECK-NEXT: local.get $push95=, 3
; CHECK-NEXT: i32.const $push34=, 16
; CHECK-NEXT: i32.add $push35=, $pop95, $pop34
; CHECK-NEXT: local.get $push96=, 3
; CHECK-NEXT: i64.load $push21=, 32($pop96)
; CHECK-NEXT: local.get $push97=, 3
; CHECK-NEXT: i32.const $push36=, 32
; CHECK-NEXT: i32.add $push37=, $pop97, $pop36
; CHECK-NEXT: i32.const $push66=, 8
; CHECK-NEXT: i32.add $push19=, $pop37, $pop66
; CHECK-NEXT: i64.load $push20=, 0($pop19)
; CHECK-NEXT: call coshl, $pop35, $pop21, $pop20
; CHECK-NEXT: local.get $push100=, 3
; CHECK-NEXT: local.get $push98=, 3
; CHECK-NEXT: i64.load $push24=, 16($pop98)
; CHECK-NEXT: local.get $push99=, 3
; CHECK-NEXT: i32.const $push32=, 16
; CHECK-NEXT: i32.add $push33=, $pop99, $pop32
; CHECK-NEXT: i32.const $push65=, 8
; CHECK-NEXT: i32.add $push22=, $pop33, $pop65
; CHECK-NEXT: i64.load $push23=, 0($pop22)
; CHECK-NEXT: call tanhl, $pop100, $pop24, $pop23
; CHECK-NEXT: local.get $push102=, 0
; CHECK-NEXT: local.get $push101=, 3
; CHECK-NEXT: i32.const $push64=, 8
; CHECK-NEXT: i32.add $push25=, $pop101, $pop64
; CHECK-NEXT: i64.load $push26=, 0($pop25)
; CHECK-NEXT: i64.store 8($pop102), $pop26
; CHECK-NEXT: local.get $push104=, 0
; CHECK-NEXT: local.get $push103=, 3
; CHECK-NEXT: i64.load $push27=, 0($pop103)
; CHECK-NEXT: i64.store 0($pop104), $pop27
; CHECK-NEXT: local.get $push105=, 3
; CHECK-NEXT: i32.const $push30=, 144
; CHECK-NEXT: i32.add $push31=, $pop105, $pop30
; CHECK-NEXT: global.set __stack_pointer, $pop31
; CHECK-NEXT: global.get $push31=, __stack_pointer
; CHECK-NEXT: i32.const $push32=, 160
; CHECK-NEXT: i32.sub $push81=, $pop31, $pop32
; CHECK-NEXT: local.tee $push80=, 3, $pop81
; CHECK-NEXT: global.set __stack_pointer, $pop80
; CHECK-NEXT: local.get $push82=, 3
; CHECK-NEXT: i32.const $push69=, 144
; CHECK-NEXT: i32.add $push70=, $pop82, $pop69
; CHECK-NEXT: local.get $push84=, 1
; CHECK-NEXT: local.get $push83=, 2
; CHECK-NEXT: call sinl, $pop70, $pop84, $pop83
; CHECK-NEXT: local.get $push85=, 3
; CHECK-NEXT: i32.const $push65=, 128
; CHECK-NEXT: i32.add $push66=, $pop85, $pop65
; CHECK-NEXT: local.get $push86=, 3
; CHECK-NEXT: i64.load $push3=, 144($pop86)
; CHECK-NEXT: local.get $push87=, 3
; CHECK-NEXT: i32.const $push67=, 144
; CHECK-NEXT: i32.add $push68=, $pop87, $pop67
; CHECK-NEXT: i32.const $push0=, 8
; CHECK-NEXT: i32.add $push1=, $pop68, $pop0
; CHECK-NEXT: i64.load $push2=, 0($pop1)
; CHECK-NEXT: call cosl, $pop66, $pop3, $pop2
; CHECK-NEXT: local.get $push88=, 3
; CHECK-NEXT: i32.const $push61=, 112
; CHECK-NEXT: i32.add $push62=, $pop88, $pop61
; CHECK-NEXT: local.get $push89=, 3
; CHECK-NEXT: i64.load $push6=, 128($pop89)
; CHECK-NEXT: local.get $push90=, 3
; CHECK-NEXT: i32.const $push63=, 128
; CHECK-NEXT: i32.add $push64=, $pop90, $pop63
; CHECK-NEXT: i32.const $push79=, 8
; CHECK-NEXT: i32.add $push4=, $pop64, $pop79
; CHECK-NEXT: i64.load $push5=, 0($pop4)
; CHECK-NEXT: call tanl, $pop62, $pop6, $pop5
; CHECK-NEXT: local.get $push91=, 3
; CHECK-NEXT: i32.const $push57=, 96
; CHECK-NEXT: i32.add $push58=, $pop91, $pop57
; CHECK-NEXT: local.get $push92=, 3
; CHECK-NEXT: i64.load $push9=, 112($pop92)
; CHECK-NEXT: local.get $push93=, 3
; CHECK-NEXT: i32.const $push59=, 112
; CHECK-NEXT: i32.add $push60=, $pop93, $pop59
; CHECK-NEXT: i32.const $push78=, 8
; CHECK-NEXT: i32.add $push7=, $pop60, $pop78
; CHECK-NEXT: i64.load $push8=, 0($pop7)
; CHECK-NEXT: call asinl, $pop58, $pop9, $pop8
; CHECK-NEXT: local.get $push94=, 3
; CHECK-NEXT: i32.const $push53=, 80
; CHECK-NEXT: i32.add $push54=, $pop94, $pop53
; CHECK-NEXT: local.get $push95=, 3
; CHECK-NEXT: i64.load $push12=, 96($pop95)
; CHECK-NEXT: local.get $push96=, 3
; CHECK-NEXT: i32.const $push55=, 96
; CHECK-NEXT: i32.add $push56=, $pop96, $pop55
; CHECK-NEXT: i32.const $push77=, 8
; CHECK-NEXT: i32.add $push10=, $pop56, $pop77
; CHECK-NEXT: i64.load $push11=, 0($pop10)
; CHECK-NEXT: call acosl, $pop54, $pop12, $pop11
; CHECK-NEXT: local.get $push97=, 3
; CHECK-NEXT: i32.const $push49=, 64
; CHECK-NEXT: i32.add $push50=, $pop97, $pop49
; CHECK-NEXT: local.get $push98=, 3
; CHECK-NEXT: i64.load $push15=, 80($pop98)
; CHECK-NEXT: local.get $push99=, 3
; CHECK-NEXT: i32.const $push51=, 80
; CHECK-NEXT: i32.add $push52=, $pop99, $pop51
; CHECK-NEXT: i32.const $push76=, 8
; CHECK-NEXT: i32.add $push13=, $pop52, $pop76
; CHECK-NEXT: i64.load $push14=, 0($pop13)
; CHECK-NEXT: call atanl, $pop50, $pop15, $pop14
; CHECK-NEXT: local.get $push100=, 3
; CHECK-NEXT: i32.const $push45=, 48
; CHECK-NEXT: i32.add $push46=, $pop100, $pop45
; CHECK-NEXT: local.get $push101=, 3
; CHECK-NEXT: i64.load $push18=, 64($pop101)
; CHECK-NEXT: local.get $push102=, 3
; CHECK-NEXT: i32.const $push47=, 64
; CHECK-NEXT: i32.add $push48=, $pop102, $pop47
; CHECK-NEXT: i32.const $push75=, 8
; CHECK-NEXT: i32.add $push16=, $pop48, $pop75
; CHECK-NEXT: i64.load $push17=, 0($pop16)
; CHECK-NEXT: call sinhl, $pop46, $pop18, $pop17
; CHECK-NEXT: local.get $push103=, 3
; CHECK-NEXT: i32.const $push41=, 32
; CHECK-NEXT: i32.add $push42=, $pop103, $pop41
; CHECK-NEXT: local.get $push104=, 3
; CHECK-NEXT: i64.load $push21=, 48($pop104)
; CHECK-NEXT: local.get $push105=, 3
; CHECK-NEXT: i32.const $push43=, 48
; CHECK-NEXT: i32.add $push44=, $pop105, $pop43
; CHECK-NEXT: i32.const $push74=, 8
; CHECK-NEXT: i32.add $push19=, $pop44, $pop74
; CHECK-NEXT: i64.load $push20=, 0($pop19)
; CHECK-NEXT: call coshl, $pop42, $pop21, $pop20
; CHECK-NEXT: local.get $push106=, 3
; CHECK-NEXT: i32.const $push37=, 16
; CHECK-NEXT: i32.add $push38=, $pop106, $pop37
; CHECK-NEXT: local.get $push107=, 3
; CHECK-NEXT: i64.load $push24=, 32($pop107)
; CHECK-NEXT: local.get $push108=, 3
; CHECK-NEXT: i32.const $push39=, 32
; CHECK-NEXT: i32.add $push40=, $pop108, $pop39
; CHECK-NEXT: i32.const $push73=, 8
; CHECK-NEXT: i32.add $push22=, $pop40, $pop73
; CHECK-NEXT: i64.load $push23=, 0($pop22)
; CHECK-NEXT: call tanhl, $pop38, $pop24, $pop23
; CHECK-NEXT: local.get $push113=, 3
; CHECK-NEXT: local.get $push112=, 1
; CHECK-NEXT: local.get $push111=, 2
; CHECK-NEXT: local.get $push109=, 3
; CHECK-NEXT: i64.load $push27=, 16($pop109)
; CHECK-NEXT: local.get $push110=, 3
; CHECK-NEXT: i32.const $push35=, 16
; CHECK-NEXT: i32.add $push36=, $pop110, $pop35
; CHECK-NEXT: i32.const $push72=, 8
; CHECK-NEXT: i32.add $push25=, $pop36, $pop72
; CHECK-NEXT: i64.load $push26=, 0($pop25)
; CHECK-NEXT: call atan2l, $pop113, $pop112, $pop111, $pop27, $pop26
; CHECK-NEXT: local.get $push115=, 0
; CHECK-NEXT: local.get $push114=, 3
; CHECK-NEXT: i32.const $push71=, 8
; CHECK-NEXT: i32.add $push28=, $pop114, $pop71
; CHECK-NEXT: i64.load $push29=, 0($pop28)
; CHECK-NEXT: i64.store 8($pop115), $pop29
; CHECK-NEXT: local.get $push117=, 0
; CHECK-NEXT: local.get $push116=, 3
; CHECK-NEXT: i64.load $push30=, 0($pop116)
; CHECK-NEXT: i64.store 0($pop117), $pop30
; CHECK-NEXT: local.get $push118=, 3
; CHECK-NEXT: i32.const $push33=, 160
; CHECK-NEXT: i32.add $push34=, $pop118, $pop33
; CHECK-NEXT: global.set __stack_pointer, $pop34
; CHECK-NEXT: return
; libm calls
%d = call fp128 @llvm.sin.f128(fp128 %x)
%e = call fp128 @llvm.cos.f128(fp128 %d)
%f = call fp128 @llvm.tan.f128(fp128 %e)
%g = call fp128 @llvm.asin.f128.i32(fp128 %f)
%g = call fp128 @llvm.asin.f128(fp128 %f)
%h = call fp128 @llvm.acos.f128(fp128 %g)
%i = call fp128 @llvm.atan.f128(fp128 %h)
%a = call fp128 @llvm.sinh.f128(fp128 %i)
%b = call fp128 @llvm.cosh.f128(fp128 %a)
%c = call fp128 @llvm.tanh.f128(fp128 %b)
ret fp128 %c
%j = call fp128 @llvm.atan2.f128(fp128 %x, fp128 %c)
ret fp128 %j
}

define double @f64libcalls(double %x) {
; CHECK-LABEL: f64libcalls:
; CHECK: .functype f64libcalls (f64) -> (f64)
; CHECK-NEXT: # %bb.0:
; CHECK-NEXT: local.get $push9=, 0
; CHECK-NEXT: call $push0=, sin, $pop9
; CHECK-NEXT: call $push1=, cos, $pop0
; CHECK-NEXT: call $push2=, tan, $pop1
; CHECK-NEXT: call $push3=, asin, $pop2
; CHECK-NEXT: call $push4=, acos, $pop3
; CHECK-NEXT: call $push5=, atan, $pop4
; CHECK-NEXT: call $push6=, sinh, $pop5
; CHECK-NEXT: call $push7=, cosh, $pop6
; CHECK-NEXT: call $push8=, tanh, $pop7
; CHECK-NEXT: return $pop8
; CHECK-NEXT: local.get $push11=, 0
; CHECK-NEXT: local.get $push10=, 0
; CHECK-NEXT: call $push0=, sin, $pop10
; CHECK-NEXT: call $push1=, cos, $pop0
; CHECK-NEXT: call $push2=, tan, $pop1
; CHECK-NEXT: call $push3=, asin, $pop2
; CHECK-NEXT: call $push4=, acos, $pop3
; CHECK-NEXT: call $push5=, atan, $pop4
; CHECK-NEXT: call $push6=, sinh, $pop5
; CHECK-NEXT: call $push7=, cosh, $pop6
; CHECK-NEXT: call $push8=, tanh, $pop7
; CHECK-NEXT: call $push9=, atan2, $pop11, $pop8
; CHECK-NEXT: return $pop9


%k = call double @llvm.sin.f64(double %x)
Expand All @@ -201,24 +221,27 @@ define double @f64libcalls(double %x) {
%f = call double @llvm.sinh.f64(double %e)
%g = call double @llvm.cosh.f64(double %f)
%h = call double @llvm.tanh.f64(double %g)
ret double %h
%i = call double @llvm.atan2.f64(double %x, double %h)
ret double %i
}

define float @f32libcalls(float %x) {
; CHECK-LABEL: f32libcalls:
; CHECK: .functype f32libcalls (f32) -> (f32)
; CHECK-NEXT: # %bb.0:
; CHECK-NEXT: local.get $push9=, 0
; CHECK-NEXT: call $push0=, sinf, $pop9
; CHECK-NEXT: call $push1=, cosf, $pop0
; CHECK-NEXT: call $push2=, tanf, $pop1
; CHECK-NEXT: call $push3=, asinf, $pop2
; CHECK-NEXT: call $push4=, acosf, $pop3
; CHECK-NEXT: call $push5=, atanf, $pop4
; CHECK-NEXT: call $push6=, sinhf, $pop5
; CHECK-NEXT: call $push7=, coshf, $pop6
; CHECK-NEXT: call $push8=, tanhf, $pop7
; CHECK-NEXT: return $pop8
; CHECK-NEXT: local.get $push11=, 0
; CHECK-NEXT: local.get $push10=, 0
; CHECK-NEXT: call $push0=, sinf, $pop10
; CHECK-NEXT: call $push1=, cosf, $pop0
; CHECK-NEXT: call $push2=, tanf, $pop1
; CHECK-NEXT: call $push3=, asinf, $pop2
; CHECK-NEXT: call $push4=, acosf, $pop3
; CHECK-NEXT: call $push5=, atanf, $pop4
; CHECK-NEXT: call $push6=, sinhf, $pop5
; CHECK-NEXT: call $push7=, coshf, $pop6
; CHECK-NEXT: call $push8=, tanhf, $pop7
; CHECK-NEXT: call $push9=, atan2f, $pop11, $pop8
; CHECK-NEXT: return $pop9


%k = call float @llvm.sin.f32(float %x)
Expand All @@ -230,5 +253,6 @@ define float @f32libcalls(float %x) {
%f = call float @llvm.sinh.f32(float %e)
%g = call float @llvm.cosh.f32(float %f)
%h = call float @llvm.tanh.f32(float %g)
ret float %h
%i = call float @llvm.atan2.f32(float %x, float %h)
ret float %i
}
Loading