Skip to content

[NFC] [CMake] Add -Wno-dangling-else for GCC built unittests #112817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 26, 2024
Merged

[NFC] [CMake] Add -Wno-dangling-else for GCC built unittests #112817

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51049ec
[NFC] Fix dangling-else warning
jsji Oct 18, 2024
0a5a061
Revert "[NFC] Fix dangling-else warning"
jsji Oct 18, 2024
fc75fa2
disable dangling else for gcc
jsji Oct 18, 2024
2015b06
Update comments
jsji Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions llvm/unittests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ function(add_llvm_target_unittest test_dir_name)
add_llvm_unittest(${test_dir_name} DISABLE_LLVM_LINK_LLVM_DYLIB ${ARGN})
endfunction()

# GCC may emit false positive warnings against LLVM's style guide.
Copy link
Contributor

@teresajohnson teresajohnson Oct 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you expand the comment to note that this is because of the gtest macro expansion.

Copy link
Member Author

@jsji jsji Oct 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Done. Thanks @teresajohnson !

if (CMAKE_COMPILER_IS_GNUCXX)
list(APPEND LLVM_COMPILE_FLAGS "-Wno-dangling-else")
endif ()

add_subdirectory(ADT)
add_subdirectory(Analysis)
add_subdirectory(AsmParser)
Expand Down
Loading