Skip to content

[DebugInfo] Add explicit visibility macros to CodeView template functions #113102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+30 −2
Open

[DebugInfo] Add explicit visibility macros to CodeView template functions #113102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79408f0
[DebugInfo] Add explicit visibility macros to CodeView template funct…
fsfod Aug 12, 2024
0d42923
Fix formatting
fsfod Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class ClassRecord;
class EnumRecord;
class ModifierRecord;
class PointerRecord;
struct UnionRecord;
class UnionRecord;
} // namespace codeview
} // namespace llvm

Expand Down
14 changes: 14 additions & 0 deletions llvm/include/llvm/DebugInfo/CodeView/ContinuationRecordBuilder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,20 @@ class ContinuationRecordBuilder {

std::vector<CVType> end(TypeIndex Index);
};

// Needed by RandomAccessVisitorTest.cpp
#define TYPE_RECORD(EnumName, EnumVal, Name)
#define TYPE_RECORD_ALIAS(EnumName, EnumVal, Name, AliasName)
#define MEMBER_RECORD(EnumName, EnumVal, Name) \
extern template LLVM_TEMPLATE_ABI void \
ContinuationRecordBuilder::writeMemberType(Name##Record &Record);
#define MEMBER_RECORD_ALIAS(EnumName, EnumVal, Name, AliasName)
#include "llvm/DebugInfo/CodeView/CodeViewTypes.def"
#undef TYPE_RECORD
#undef TYPE_RECORD_ALIAS
#undef MEMBER_RECORD
#undef MEMBER_RECORD_ALIAS
Copy link
Member

@compnerd compnerd Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would double check that this works with modular builds, this seems like it could cause some issues.


} // namespace codeview
} // namespace llvm

Expand Down
13 changes: 13 additions & 0 deletions llvm/include/llvm/DebugInfo/CodeView/SimpleTypeSerializer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,19 @@ class SimpleTypeSerializer {
ArrayRef<uint8_t> serialize(const FieldListRecord &Record) = delete;
};

// Needed by RandomAccessVisitorTest.cpp
#define TYPE_RECORD(EnumName, EnumVal, Name) \
class Name##Record; \
extern template LLVM_TEMPLATE_ABI ArrayRef<uint8_t> \
llvm::codeview::SimpleTypeSerializer::serialize(Name##Record &Record);
#define TYPE_RECORD_ALIAS(EnumName, EnumVal, Name, AliasName)
#define MEMBER_RECORD(EnumName, EnumVal, Name)
#define MEMBER_RECORD_ALIAS(EnumName, EnumVal, Name, AliasName)
#include "llvm/DebugInfo/CodeView/CodeViewTypes.def"
#undef TYPE_RECORD
#undef TYPE_RECORD_ALIAS
#undef MEMBER_RECORD
#undef MEMBER_RECORD_ALIAS
Copy link
Member

@compnerd compnerd Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise

} // end namespace codeview
} // end namespace llvm

Expand Down
3 changes: 2 additions & 1 deletion llvm/include/llvm/DebugInfo/CodeView/TypeRecord.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,8 @@ class ClassRecord : public TagRecord {
};

// LF_UNION
struct UnionRecord : public TagRecord {
class UnionRecord : public TagRecord {
public:
Copy link
Member

@compnerd compnerd Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change here? The use of struct should be fine. Or was it that there was a conflict with the declaration from the XMACRO?

Copy link
Contributor Author

@fsfod fsfod Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it wasn't usable in the XMACRO to forward declare classes used for the function declarations it creates

UnionRecord() = default;
explicit UnionRecord(TypeRecordKind Kind) : TagRecord(Kind) {}
UnionRecord(uint16_t MemberCount, ClassOptions Options, TypeIndex FieldList,
Expand Down