Skip to content

[BOLT] link_fdata support for hardcoded offsets in no-LBR #113157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[BOLT] link_fdata support for hardcoded offsets in no-LBR #113157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55a40d3
link_fdata does not support hardcoded offsets in no-LBR mode
paschalis-mpeis Oct 15, 2024
3d5a924
[BOLT] link_fdata support for hardcoded offsets in no-LBR
paschalis-mpeis Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions bolt/test/AArch64/fdata-nolbr.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Check that using link_fdata tool in non-lbr mode allows using hardcoded
# addresses for basic block offsets.

# REQUIRES: system-linux

# RUN: %clang %cflags -o %t %s
# RUN: %clang %s %cflags -Wl,-q -o %t
# RUN: link_fdata --no-lbr %s %t %t.fdata
# RUN: cat %t.fdata | FileCheck %s

.text
.globl foo
.type foo, %function
foo:
# FDATA: 1 foo 0 10
ret

# CHECK: no_lbr
# CHECK-NEXT: 1 foo 0 10
2 changes: 1 addition & 1 deletion bolt/test/link_fdata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
fdata_match = fdata_pat.match(profile_line)
preagg_match = preagg_pat.match(profile_line)
nolbr_match = nolbr_pat.match(profile_line)
if fdata_match:
if fdata_match and not (nolbr_match and args.no_lbr):
src_dst, execnt, mispred = fdata_match.groups()
# Split by whitespaces not preceded by a backslash (negative lookbehind)
chunks = re.split(r"(?<!\\) +", src_dst)
Expand Down
Loading