From 0d27f7643007805bc2b1f2965edbd71d6563dae3 Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Mon, 21 Oct 2024 19:29:50 -0700 Subject: [PATCH 1/2] [lldb][test] Fix TestUseSourceCache for readonly source trees TestUseSourceCache attempts to write to a build artifact copied from the source tree, and asserts the write succeeded. If the source tree is read only, the copy will also be read only, causing it to fail. When producing the build artifact, ensure that it is writable. I use `chmod` as a build step to do this, but I believe that is linuxish-only thing, so I excluded this extra command for Windows. --- lldb/test/API/commands/settings/use_source_cache/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lldb/test/API/commands/settings/use_source_cache/Makefile b/lldb/test/API/commands/settings/use_source_cache/Makefile index 791cb7d868d87..0090acf5591da 100644 --- a/lldb/test/API/commands/settings/use_source_cache/Makefile +++ b/lldb/test/API/commands/settings/use_source_cache/Makefile @@ -6,3 +6,6 @@ include Makefile.rules # Copy file into the build folder to enable the test to modify it. main-copy.cpp: main.cpp cp -f $< $@ +ifneq "$(OS)" "Windows_NT" # chmod is not available on Windows + chmod u+w $@ +endif From ffec54648ac581c7d43cc406b9b7a0b53fd4a331 Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Tue, 22 Oct 2024 07:45:02 -0700 Subject: [PATCH 2/2] Remove windows guard --- lldb/test/API/commands/settings/use_source_cache/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/lldb/test/API/commands/settings/use_source_cache/Makefile b/lldb/test/API/commands/settings/use_source_cache/Makefile index 0090acf5591da..6c1c64fae074d 100644 --- a/lldb/test/API/commands/settings/use_source_cache/Makefile +++ b/lldb/test/API/commands/settings/use_source_cache/Makefile @@ -6,6 +6,4 @@ include Makefile.rules # Copy file into the build folder to enable the test to modify it. main-copy.cpp: main.cpp cp -f $< $@ -ifneq "$(OS)" "Windows_NT" # chmod is not available on Windows chmod u+w $@ -endif