[ORC] Add visibility macros to functions needed by lli and jitlink #113271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annotating these symbols will fix missing symbols errors for lli and llvm-jitlink when when the LLVM is built as shared library on windows with explicit symbol visibility macros enabled. This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and plugins on window.
Open
40 tasks
vgvassilev
reviewed
Oct 23, 2024
Contributor
vgvassilev
left a comment
vgvassilev
left a comment
There was a problem hiding this comment.
This seems a good change to me. Will leave say to @lhames.
lhames
approved these changes
Oct 24, 2024
Closed
NoumanAmir657
pushed a commit
to NoumanAmir657/llvm-project
that referenced
this pull request
Nov 4, 2024
…lvm#113271) Annotating these symbols will fix missing symbols errors for lli and llvm-jitlink when when the LLVM is built as shared library on windows with explicit symbol visibility macros enabled. This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and plugins on window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotating these symbols will fix missing symbols errors for lli and llvm-jitlink when when the LLVM is built as shared library on windows with explicit symbol visibility macros enabled.
This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and plugins on window.