[NFC] Eliminate use of lookupLLVMIntrinsicByName in Coroutines
#114851
Conversation
Eliminate use of `lookupLLVMIntrinsicByName` from Coroutines in preparation of changing it to support a different form of intrinsic name table generated by intrinsic emitter. Also eliminate call to `isCoroutineIntrinsicName` from `declaresAnyIntrinsic` as the list of names traversed is the same list which `isCoroutineIntrinsicName` checks.
jurahul
force-pushed
the
fixup_isCoroutineIntrinsicName
branch
from
ec725fd to
5c80973
Compare
|
@llvm/pr-subscribers-coroutines Author: Rahul Joshi (jurahul) ChangesEliminate use of Also eliminate call to Full diff: https://github.com/llvm/llvm-project/pull/114851.diff 1 Files Affected:
diff --git a/llvm/lib/Transforms/Coroutines/Coroutines.cpp b/llvm/lib/Transforms/Coroutines/Coroutines.cpp
index 45b9767657c66a..331a9c942ae600 100644
--- a/llvm/lib/Transforms/Coroutines/Coroutines.cpp
+++ b/llvm/lib/Transforms/Coroutines/Coroutines.cpp
@@ -100,8 +100,7 @@ static const char *const CoroIntrinsics[] = {
#ifndef NDEBUG
static bool isCoroutineIntrinsicName(StringRef Name) {
- return Intrinsic::lookupLLVMIntrinsicByName(CoroIntrinsics, Name, "coro") !=
- -1;
+ return llvm::binary_search(CoroIntrinsics, Name);
}
#endif
@@ -111,7 +110,6 @@ bool coro::isSuspendBlock(BasicBlock *BB) {
bool coro::declaresAnyIntrinsic(const Module &M) {
for (StringRef Name : CoroIntrinsics) {
- assert(isCoroutineIntrinsicName(Name) && "not a coroutine intrinsic");
if (M.getNamedValue(Name))
return true;
}
|
|
@llvm/pr-subscribers-llvm-transforms Author: Rahul Joshi (jurahul) ChangesEliminate use of Also eliminate call to Full diff: https://github.com/llvm/llvm-project/pull/114851.diff 1 Files Affected:
diff --git a/llvm/lib/Transforms/Coroutines/Coroutines.cpp b/llvm/lib/Transforms/Coroutines/Coroutines.cpp
index 45b9767657c66a..331a9c942ae600 100644
--- a/llvm/lib/Transforms/Coroutines/Coroutines.cpp
+++ b/llvm/lib/Transforms/Coroutines/Coroutines.cpp
@@ -100,8 +100,7 @@ static const char *const CoroIntrinsics[] = {
#ifndef NDEBUG
static bool isCoroutineIntrinsicName(StringRef Name) {
- return Intrinsic::lookupLLVMIntrinsicByName(CoroIntrinsics, Name, "coro") !=
- -1;
+ return llvm::binary_search(CoroIntrinsics, Name);
}
#endif
@@ -111,7 +110,6 @@ bool coro::isSuspendBlock(BasicBlock *BB) {
bool coro::declaresAnyIntrinsic(const Module &M) {
for (StringRef Name : CoroIntrinsics) {
- assert(isCoroutineIntrinsicName(Name) && "not a coroutine intrinsic");
if (M.getNamedValue(Name))
return true;
}
|
|
Thanks @ChuanqiXu9. Will wait for a couple of days to give other reviewers a chance to review. |
3 participants
Eliminate use of
lookupLLVMIntrinsicByNamefrom Coroutines in preparation of changing it to support a different form of intrinsic name table generated by intrinsic emitter.Also eliminate call to
isCoroutineIntrinsicNamefromdeclaresAnyIntrinsicas the list of names traversed is the same list whichisCoroutineIntrinsicNamechecks.