Add Chris as the HLSL maintainer #114863
Merged
Add Chris as the HLSL maintainer #114863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris has extensive knowledge of HLSL and a long track-record of quality reviews in Clang.
Member
|
@llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) ChangesChris has extensive knowledge of HLSL and a long track-record of quality reviews in Clang. Full diff: https://github.com/llvm/llvm-project/pull/114863.diff 1 Files Affected:
diff --git a/clang/Maintainers.rst b/clang/Maintainers.rst
index 694ebc691107cb..1fbe8edeb00e8a 100644
--- a/clang/Maintainers.rst
+++ b/clang/Maintainers.rst
@@ -295,6 +295,12 @@ SYCL conformance
| alexey.bader\@intel.com (email), bader (Phabricator), bader (GitHub)
+HLSL conformance
+~~~~~~~~~~~~~~~~
+| Chris Bieneman
+| chris.bieneman\@gmail.com (email), llvm-beanz (GitHub), beanz (Discord), beanz (Discourse)
+
+
Issue Triage
~~~~~~~~~~~~
| Shafik Yaghmour
|
llvm-beanz
approved these changes
Nov 4, 2024
Collaborator
llvm-beanz
left a comment
llvm-beanz
left a comment
There was a problem hiding this comment.
Thank you for the vote of confidence 😄
erichkeane
approved these changes
Nov 5, 2024
PhilippRados
pushed a commit
to PhilippRados/llvm-project
that referenced
this pull request
Nov 6, 2024
Chris has extensive knowledge of HLSL and a long track-record of quality reviews in Clang.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chris has extensive knowledge of HLSL and a long track-record of quality reviews in Clang.