[dsymutil] Add missing newlines in error messages. #115191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-debuginfo Author: Ryan Mansfield (rjmansfield) ChangesErrors like "cannot create bundle: Not a directory" or "error: a.out.dSYM: Is a directory" were being emitted without a newline. Full diff: https://github.com/llvm/llvm-project/pull/115191.diff 1 Files Affected:
diff --git a/llvm/tools/dsymutil/dsymutil.cpp b/llvm/tools/dsymutil/dsymutil.cpp
index 754d3a0f26c3d1..2ace7180b00808 100644
--- a/llvm/tools/dsymutil/dsymutil.cpp
+++ b/llvm/tools/dsymutil/dsymutil.cpp
@@ -714,7 +714,7 @@ int dsymutil_main(int argc, char **argv, const llvm::ToolContext &) {
Expected<OutputLocation> OutputLocationOrErr =
getOutputFileName(InputFile, Options);
if (!OutputLocationOrErr) {
- WithColor::error() << toString(OutputLocationOrErr.takeError());
+ WithColor::error() << toString(OutputLocationOrErr.takeError()) << "\n";
return EXIT_FAILURE;
}
Options.LinkOpts.ResourceDir = OutputLocationOrErr->getResourceDir();
@@ -792,7 +792,7 @@ int dsymutil_main(int argc, char **argv, const llvm::ToolContext &) {
Options.LinkOpts.NoOutput ? "-" : OutputFile, EC,
sys::fs::OF_None);
if (EC) {
- WithColor::error() << OutputFile << ": " << EC.message();
+ WithColor::error() << OutputFile << ": " << EC.message() << "\n";
AllOK.fetch_and(false);
return;
}
|
JDevlieghere
approved these changes
Nov 6, 2024
JDevlieghere
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Nov 7, 2024
Errors like "cannot create bundle: Not a directory" or "error: a.out.dSYM: Is a directory" were being emitted without a newline. (cherry picked from commit bbc3af0)
JDevlieghere
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Nov 7, 2024
[dsymutil] Add missing newlines in error messages. (llvm#115191)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors like "cannot create bundle: Not a directory" or "error: a.out.dSYM: Is a directory" were being emitted without a newline.