diff --git a/libcxx/include/__vector/vector_bool.h b/libcxx/include/__vector/vector_bool.h index 3b03f65b7ee54..36eb7f350ac40 100644 --- a/libcxx/include/__vector/vector_bool.h +++ b/libcxx/include/__vector/vector_bool.h @@ -390,18 +390,12 @@ class _LIBCPP_TEMPLATE_VIS vector { template _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 void __init_with_sentinel(_InputIterator __first, _Sentinel __last) { -#if _LIBCPP_HAS_EXCEPTIONS - try { -#endif // _LIBCPP_HAS_EXCEPTIONS - for (; __first != __last; ++__first) - push_back(*__first); -#if _LIBCPP_HAS_EXCEPTIONS - } catch (...) { - if (__begin_ != nullptr) - __storage_traits::deallocate(__alloc_, __begin_, __cap_); - throw; - } -#endif // _LIBCPP_HAS_EXCEPTIONS + auto __guard = std::__make_exception_guard(__destroy_vector(*this)); + + for (; __first != __last; ++__first) + push_back(*__first); + + __guard.__complete(); } template diff --git a/libcxx/test/std/containers/sequences/vector.bool/ctor_exceptions.pass.cpp b/libcxx/test/std/containers/sequences/vector.bool/ctor_exceptions.pass.cpp index 928fceab1f078..cb2b7d124edc1 100644 --- a/libcxx/test/std/containers/sequences/vector.bool/ctor_exceptions.pass.cpp +++ b/libcxx/test/std/containers/sequences/vector.bool/ctor_exceptions.pass.cpp @@ -12,121 +12,80 @@ // Check that vector constructors don't leak memory when an operation inside the constructor throws an exception #include -#include #include +#include #include +#include "../vector/common.h" #include "count_new.h" #include "test_iterators.h" -template -struct Allocator { - using value_type = T; - using is_always_equal = std::false_type; - - template - Allocator(const Allocator&) {} - - Allocator(bool should_throw = true) { - if (should_throw) - throw 0; - } - - T* allocate(std::size_t n) { return std::allocator().allocate(n); } - void deallocate(T* ptr, std::size_t n) { std::allocator().deallocate(ptr, n); } - - template - friend bool operator==(const Allocator&, const Allocator&) { return true; } -}; - -template -struct Iterator { - using iterator_category = IterCat; - using difference_type = std::ptrdiff_t; - using value_type = bool; - using reference = bool&; - using pointer = bool*; - - int i_; - bool b_ = true; - Iterator(int i = 0) : i_(i) {} - bool& operator*() { - if (i_ == 1) - throw 1; - return b_; - } - - friend bool operator==(const Iterator& lhs, const Iterator& rhs) { return lhs.i_ == rhs.i_; } - - friend bool operator!=(const Iterator& lhs, const Iterator& rhs) { return lhs.i_ != rhs.i_; } - - Iterator& operator++() { - ++i_; - return *this; - } +int main(int, char**) { + using AllocVec = std::vector >; - Iterator operator++(int) { - auto tmp = *this; - ++i_; - return tmp; + try { // Throw in vector() from allocator + AllocVec vec; + } catch (int) { } -}; - -void check_new_delete_called() { - assert(globalMemCounter.new_called == globalMemCounter.delete_called); - assert(globalMemCounter.new_array_called == globalMemCounter.delete_array_called); - assert(globalMemCounter.aligned_new_called == globalMemCounter.aligned_delete_called); - assert(globalMemCounter.aligned_new_array_called == globalMemCounter.aligned_delete_array_called); -} - -int main(int, char**) { - using AllocVec = std::vector >; + check_new_delete_called(); #if TEST_STD_VER >= 14 try { // Throw in vector(size_type, const allocator_type&) from allocator - Allocator alloc(false); + throwing_allocator alloc(/*throw_on_ctor = */ false, /*throw_on_copy = */ true); AllocVec get_alloc(0, alloc); } catch (int) { } check_new_delete_called(); -#endif // TEST_STD_VER >= 14 +#endif // TEST_STD_VER >= 14 + + try { // Throw in vector(size_type, const value_type&, const allocator_type&) from allocator + throwing_allocator alloc(/*throw_on_ctor = */ false, /*throw_on_copy = */ true); + AllocVec get_alloc(0, true, alloc); + } catch (int) { + } + check_new_delete_called(); try { // Throw in vector(InputIterator, InputIterator) from input iterator - std::vector vec((Iterator()), Iterator(2)); + std::vector vec( + throwing_iterator(), throwing_iterator(2)); } catch (int) { } check_new_delete_called(); try { // Throw in vector(InputIterator, InputIterator) from forward iterator - std::vector vec((Iterator()), Iterator(2)); + std::vector vec( + throwing_iterator(), throwing_iterator(2)); } catch (int) { } check_new_delete_called(); try { // Throw in vector(InputIterator, InputIterator) from allocator - int a[] = {1, 2}; - AllocVec vec(cpp17_input_iterator(a), cpp17_input_iterator(a + 2)); + bool a[] = {true, true}; + AllocVec vec(cpp17_input_iterator(a), cpp17_input_iterator(a + 2)); } catch (int) { } check_new_delete_called(); try { // Throw in vector(InputIterator, InputIterator, const allocator_type&) from input iterator std::allocator alloc; - std::vector vec(Iterator(), Iterator(2), alloc); + std::vector vec( + throwing_iterator(), throwing_iterator(2), alloc); } catch (int) { } check_new_delete_called(); try { // Throw in vector(InputIterator, InputIterator, const allocator_type&) from forward iterator std::allocator alloc; - std::vector vec(Iterator(), Iterator(2), alloc); + std::vector vec(throwing_iterator(), + throwing_iterator(2), + alloc); } catch (int) { } check_new_delete_called(); try { // Throw in vector(InputIterator, InputIterator, const allocator_type&) from allocator bool a[] = {true, false}; - Allocator alloc(false); + throwing_allocator alloc(/*throw_on_ctor = */ false, /*throw_on_copy = */ true); AllocVec vec(cpp17_input_iterator(a), cpp17_input_iterator(a + 2), alloc); } catch (int) { } @@ -134,11 +93,40 @@ int main(int, char**) { try { // Throw in vector(InputIterator, InputIterator, const allocator_type&) from allocator bool a[] = {true, false}; - Allocator alloc(false); + throwing_allocator alloc(/*throw_on_ctor = */ false, /*throw_on_copy = */ true); AllocVec vec(forward_iterator(a), forward_iterator(a + 2), alloc); } catch (int) { } check_new_delete_called(); +#if TEST_STD_VER >= 11 + try { // Throw in vector(const vector&, const allocator_type&) from allocator + throwing_allocator alloc(/*throw_on_ctor = */ false, /*throw_on_copy = */ false); + AllocVec vec(alloc); + vec.push_back(true); + alloc.throw_on_copy_ = true; + AllocVec vec2(vec, alloc); + } catch (int) { + } + check_new_delete_called(); + + try { // Throw in vector(vector&&, const allocator_type&) from allocator + throwing_allocator alloc(/*throw_on_ctor = */ false, /*throw_on_copy = */ false); + AllocVec vec(alloc); + vec.push_back(true); + alloc.throw_on_copy_ = true; + AllocVec vec2(std::move(vec), alloc); + } catch (int) { + } + check_new_delete_called(); + + try { // Throw in vector(initializer_list, const allocator_type&) constructor from allocator + throwing_allocator alloc(/*throw_on_ctor = */ false, /*throw_on_copy = */ true); + AllocVec vec({true, true}, alloc); + } catch (int) { + } + check_new_delete_called(); +#endif // TEST_STD_VER >= 11 + return 0; } diff --git a/libcxx/test/std/containers/sequences/vector/common.h b/libcxx/test/std/containers/sequences/vector/common.h new file mode 100644 index 0000000000000..e793ab2a21c1d --- /dev/null +++ b/libcxx/test/std/containers/sequences/vector/common.h @@ -0,0 +1,97 @@ +//===----------------------------------------------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#ifndef TEST_STD_CONTAINERS_SEQUENCES_VECTOR_COMMON_H +#define TEST_STD_CONTAINERS_SEQUENCES_VECTOR_COMMON_H + +#include +#include +#include +#include + +#include "count_new.h" + +template +struct throwing_allocator { + using value_type = T; + using is_always_equal = std::false_type; + + bool throw_on_copy_ = false; + + explicit throwing_allocator(bool throw_on_ctor = true) { + if (throw_on_ctor) + throw 0; + } + + explicit throwing_allocator(bool throw_on_ctor, bool throw_on_copy) : throw_on_copy_(throw_on_copy) { + if (throw_on_ctor) + throw 0; + } + + throwing_allocator(const throwing_allocator& rhs) : throw_on_copy_(rhs.throw_on_copy_) { + if (throw_on_copy_) + throw 0; + } + + template + throwing_allocator(const throwing_allocator& rhs) : throw_on_copy_(rhs.throw_on_copy_) { + if (throw_on_copy_) + throw 0; + } + + T* allocate(std::size_t n) { return std::allocator().allocate(n); } + void deallocate(T* ptr, std::size_t n) { std::allocator().deallocate(ptr, n); } + + template + friend bool operator==(const throwing_allocator&, const throwing_allocator&) { + return true; + } +}; + +template +struct throwing_iterator { + using iterator_category = IterCat; + using difference_type = std::ptrdiff_t; + using value_type = T; + using reference = T&; + using pointer = T*; + + int i_; + T v_; + + throwing_iterator(int i = 0, const T& v = T()) : i_(i), v_(v) {} + + reference operator*() { + if (i_ == 1) + throw 1; + return v_; + } + + friend bool operator==(const throwing_iterator& lhs, const throwing_iterator& rhs) { return lhs.i_ == rhs.i_; } + friend bool operator!=(const throwing_iterator& lhs, const throwing_iterator& rhs) { return lhs.i_ != rhs.i_; } + + throwing_iterator& operator++() { + ++i_; + return *this; + } + + throwing_iterator operator++(int) { + auto tmp = *this; + ++i_; + return tmp; + } +}; + +inline void check_new_delete_called() { + assert(globalMemCounter.new_called == globalMemCounter.delete_called); + assert(globalMemCounter.new_array_called == globalMemCounter.delete_array_called); + assert(globalMemCounter.aligned_new_called == globalMemCounter.aligned_delete_called); + assert(globalMemCounter.aligned_new_array_called == globalMemCounter.aligned_delete_array_called); +} + +#endif // TEST_STD_CONTAINERS_SEQUENCES_VECTOR_COMMON_H