diff --git a/llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp b/llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp index 59257fd6aadd5..a465f52bfd593 100644 --- a/llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp +++ b/llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp @@ -1051,10 +1051,10 @@ class AssignmentTrackingLowering { OS << ", s="; if (Source.isNull()) OS << "null"; - else if (isa(Source)) - OS << Source.get(); + else if (const auto *DAI = dyn_cast(Source)) + OS << DAI; else - OS << Source.get(); + OS << cast(Source); OS << ")"; } diff --git a/llvm/lib/CodeGen/GlobalISel/Utils.cpp b/llvm/lib/CodeGen/GlobalISel/Utils.cpp index 5cee07461d7e2..45807a6818ee5 100644 --- a/llvm/lib/CodeGen/GlobalISel/Utils.cpp +++ b/llvm/lib/CodeGen/GlobalISel/Utils.cpp @@ -214,8 +214,8 @@ bool llvm::canReplaceReg(Register DstReg, Register SrcReg, // Otherwise match if the Src is already a regclass that is covered by the Dst // RegBank. - return DstRBC.is() && MRI.getRegClassOrNull(SrcReg) && - DstRBC.get()->covers( + return isa(DstRBC) && MRI.getRegClassOrNull(SrcReg) && + cast(DstRBC)->covers( *MRI.getRegClassOrNull(SrcReg)); } diff --git a/llvm/lib/IR/DIBuilder.cpp b/llvm/lib/IR/DIBuilder.cpp index 665eda28c7d87..3d8e12e95b774 100644 --- a/llvm/lib/IR/DIBuilder.cpp +++ b/llvm/lib/IR/DIBuilder.cpp @@ -1033,8 +1033,8 @@ DbgInstPtr DIBuilder::insertDbgValueIntrinsic(Value *V, DbgInstPtr DVI = insertDbgValueIntrinsic( V, VarInfo, Expr, DL, InsertBefore ? InsertBefore->getParent() : nullptr, InsertBefore); - if (DVI.is()) - cast(DVI.get())->setTailCall(); + if (auto *Inst = dyn_cast(DVI)) + cast(Inst)->setTailCall(); return DVI; } diff --git a/llvm/lib/IR/DebugInfo.cpp b/llvm/lib/IR/DebugInfo.cpp index e20a0f053481e..e5b45e0082a82 100644 --- a/llvm/lib/IR/DebugInfo.cpp +++ b/llvm/lib/IR/DebugInfo.cpp @@ -2099,10 +2099,10 @@ static void emitDbgAssign(AssignmentInfo Info, Value *Val, Value *Dest, AddrExpr, VarRec.DL); (void)Assign; LLVM_DEBUG(if (!Assign.isNull()) { - if (Assign.is()) - errs() << " > INSERT: " << *Assign.get() << "\n"; + if (const auto *Record = dyn_cast(Assign)) + errs() << " > INSERT: " << *Record << "\n"; else - errs() << " > INSERT: " << *Assign.get() << "\n"; + errs() << " > INSERT: " << *cast(Assign) << "\n"; }); } diff --git a/llvm/lib/IR/Metadata.cpp b/llvm/lib/IR/Metadata.cpp index 28f2ca550f5ec..98cfbd11fde58 100644 --- a/llvm/lib/IR/Metadata.cpp +++ b/llvm/lib/IR/Metadata.cpp @@ -274,7 +274,7 @@ ReplaceableMetadataImpl::getAllDbgVariableRecordUsers() { OwnerTy Owner = Pair.second.first; if (Owner.isNull()) continue; - if (!Owner.is()) + if (!isa(Owner)) continue; DVRUsersWithID.push_back(&UseMap[Pair.first]); } @@ -288,7 +288,7 @@ ReplaceableMetadataImpl::getAllDbgVariableRecordUsers() { }); SmallVector DVRUsers; for (auto UserWithID : DVRUsersWithID) - DVRUsers.push_back(UserWithID->first.get()->getUser()); + DVRUsers.push_back(cast(UserWithID->first)->getUser()); return DVRUsers; } @@ -396,8 +396,8 @@ void ReplaceableMetadataImpl::replaceAllUsesWith(Metadata *MD) { continue; } - if (Owner.is()) { - Owner.get()->handleChangedValue(Pair.first, MD); + if (auto *DVU = dyn_cast(Owner)) { + DVU->handleChangedValue(Pair.first, MD); continue; } @@ -436,7 +436,7 @@ void ReplaceableMetadataImpl::resolveAllUses(bool ResolveUsers) { auto Owner = Pair.second.first; if (!Owner) continue; - if (!Owner.is()) + if (!isa(Owner)) continue; // Resolve MDNodes that point at this. diff --git a/llvm/lib/SandboxIR/Tracker.cpp b/llvm/lib/SandboxIR/Tracker.cpp index abcad39330094..e4f84dee07e4d 100644 --- a/llvm/lib/SandboxIR/Tracker.cpp +++ b/llvm/lib/SandboxIR/Tracker.cpp @@ -111,10 +111,10 @@ void EraseFromParent::accept() { void EraseFromParent::revert(Tracker &Tracker) { // Place the bottom-most instruction first. auto [Operands, BotLLVMI] = InstrData[0]; - if (auto *NextLLVMI = NextLLVMIOrBB.dyn_cast()) { + if (auto *NextLLVMI = dyn_cast(NextLLVMIOrBB)) { BotLLVMI->insertBefore(NextLLVMI); } else { - auto *LLVMBB = NextLLVMIOrBB.get(); + auto *LLVMBB = cast(NextLLVMIOrBB); BotLLVMI->insertInto(LLVMBB, LLVMBB->end()); } for (auto [OpNum, Op] : enumerate(Operands)) @@ -145,10 +145,10 @@ RemoveFromParent::RemoveFromParent(Instruction *RemovedI) : RemovedI(RemovedI) { } void RemoveFromParent::revert(Tracker &Tracker) { - if (auto *NextI = NextInstrOrBB.dyn_cast()) { + if (auto *NextI = dyn_cast(NextInstrOrBB)) { RemovedI->insertBefore(NextI); } else { - auto *BB = NextInstrOrBB.get(); + auto *BB = cast(NextInstrOrBB); RemovedI->insertInto(BB, BB->end()); } } @@ -199,10 +199,10 @@ MoveInstr::MoveInstr(Instruction *MovedI) : MovedI(MovedI) { } void MoveInstr::revert(Tracker &Tracker) { - if (auto *NextI = NextInstrOrBB.dyn_cast()) { + if (auto *NextI = dyn_cast(NextInstrOrBB)) { MovedI->moveBefore(NextI); } else { - auto *BB = NextInstrOrBB.get(); + auto *BB = cast(NextInstrOrBB); MovedI->moveBefore(*BB, BB->end()); } } diff --git a/llvm/lib/Transforms/Scalar/SROA.cpp b/llvm/lib/Transforms/Scalar/SROA.cpp index 4a23e2bee5ba2..d80af26451ac7 100644 --- a/llvm/lib/Transforms/Scalar/SROA.cpp +++ b/llvm/lib/Transforms/Scalar/SROA.cpp @@ -5166,11 +5166,9 @@ insertNewDbgInst(DIBuilder &DIB, DbgAssignIntrinsic *Orig, AllocaInst *NewAddr, DIAssignID::getDistinct(NewAddr->getContext())); } - Instruction *NewAssign = - DIB.insertDbgAssign(NewAddr, Orig->getValue(), Orig->getVariable(), - NewFragmentExpr, NewAddr, NewAddrExpr, - Orig->getDebugLoc()) - .get(); + Instruction *NewAssign = cast(DIB.insertDbgAssign( + NewAddr, Orig->getValue(), Orig->getVariable(), NewFragmentExpr, NewAddr, + NewAddrExpr, Orig->getDebugLoc())); LLVM_DEBUG(dbgs() << "Created new assign intrinsic: " << *NewAssign << "\n"); (void)NewAssign; } diff --git a/llvm/lib/Transforms/Utils/Local.cpp b/llvm/lib/Transforms/Utils/Local.cpp index 768765b6c1e63..509b6d6226551 100644 --- a/llvm/lib/Transforms/Utils/Local.cpp +++ b/llvm/lib/Transforms/Utils/Local.cpp @@ -1696,7 +1696,7 @@ static void insertDbgValueOrDbgVariableRecord(DIBuilder &Builder, Value *DV, if (!UseNewDbgInfoFormat) { auto DbgVal = Builder.insertDbgValueIntrinsic(DV, DIVar, DIExpr, NewLoc, (Instruction *)nullptr); - DbgVal.get()->insertBefore(Instr); + cast(DbgVal)->insertBefore(Instr); } else { // RemoveDIs: if we're using the new debug-info format, allocate a // DbgVariableRecord directly instead of a dbg.value intrinsic. @@ -1713,7 +1713,7 @@ static void insertDbgValueOrDbgVariableRecordAfter( if (!UseNewDbgInfoFormat) { auto DbgVal = Builder.insertDbgValueIntrinsic(DV, DIVar, DIExpr, NewLoc, (Instruction *)nullptr); - DbgVal.get()->insertAfter(&*Instr); + cast(DbgVal)->insertAfter(&*Instr); } else { // RemoveDIs: if we're using the new debug-info format, allocate a // DbgVariableRecord directly instead of a dbg.value intrinsic.