-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[CMake] update Apple undefined symbol link flag from suppress #116113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
the -undefined suppress option for Apple's linker is deprecated and was producing multiple warnings. This updates it to dynamic_lookup, which has much the same effect, but avoids these deprecation warnings.
|
@lgerbarg for comment/visibility. |
cooperp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks! |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/3547 Here is the relevant piece of the build log for the reference |
the -undefined suppress option for Apple's linker is deprecated and was producing multiple warnings. This updates it to dynamic_lookup, which has much the same effect, but avoids these deprecation warnings.