diff --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td index d07ebbacc6043..59174f9abc9c4 100644 --- a/mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td +++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td @@ -19,7 +19,7 @@ class LLVM_UnaryIntrOpBase { dag commonArgs = (ins LLVM_ScalarOrVectorOf:$in); - let assemblyFormat = "`(` operands `)` custom(attr-dict) `:` " + let assemblyFormat = "`(` operands `)` attr-dict `:` " "functional-type(operands, results)"; } @@ -42,7 +42,7 @@ class LLVM_BinarySameArgsIntrOpBase { dag commonArgs = (ins LLVM_ScalarOrVectorOf:$a, LLVM_ScalarOrVectorOf:$b); - let assemblyFormat = "`(` operands `)` custom(attr-dict) `:` " + let assemblyFormat = "`(` operands `)` attr-dict `:` " "functional-type(operands, results)"; } @@ -67,7 +67,7 @@ class LLVM_TernarySameArgsIntrOpBase:$a, LLVM_ScalarOrVectorOf:$b, LLVM_ScalarOrVectorOf:$c); - let assemblyFormat = "`(` operands `)` custom(attr-dict) `:` " + let assemblyFormat = "`(` operands `)` attr-dict `:` " "functional-type(operands, results)"; } @@ -137,7 +137,7 @@ def LLVM_PowIOp : LLVM_OneResultIntrOp<"powi", [], [0,1], (ins LLVM_ScalarOrVectorOf:$val, AnySignlessInteger:$power, DefaultValuedAttr:$fastmathFlags); - let assemblyFormat = "`(` operands `)` custom(attr-dict) `:` " + let assemblyFormat = "`(` operands `)` attr-dict `:` " "functional-type(operands, results)"; } def LLVM_RintOp : LLVM_UnaryIntrOpF<"rint">; @@ -145,7 +145,7 @@ def LLVM_NearbyintOp : LLVM_UnaryIntrOpF<"nearbyint">; class LLVM_IntRoundIntrOpBase : LLVM_OneResultIntrOp { let arguments = (ins LLVM_AnyFloat:$val); - let assemblyFormat = "`(` operands `)` custom(attr-dict) `:` " + let assemblyFormat = "`(` operands `)` attr-dict `:` " "functional-type(operands, results)"; } def LLVM_LroundOp : LLVM_IntRoundIntrOpBase<"lround">; @@ -706,7 +706,7 @@ class LLVM_VecReductionF ins DefaultValuedAttr:$fastmathFlags); let arguments = !con(commonArgs, fmfArg); - let assemblyFormat = "`(` operands `)` custom(attr-dict) `:` " + let assemblyFormat = "`(` operands `)` attr-dict `:` " "functional-type(operands, results)"; } diff --git a/mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td b/mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td index 34f3e4b33b829..105f28066c1f5 100644 --- a/mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td +++ b/mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td @@ -45,7 +45,7 @@ class LLVM_ArithmeticOpBase:$rhs); let results = (outs LLVM_ScalarOrVectorOf:$res); let builders = [LLVM_OneResultOpBuilder]; - let assemblyFormat = "$lhs `,` $rhs custom(attr-dict) `:` type($res)"; + let assemblyFormat = "$lhs `,` $rhs attr-dict `:` type($res)"; string llvmInstName = instName; } class LLVM_IntArithmeticOp:$fastmathFlags); let results = (outs type:$res); let builders = [LLVM_OneResultOpBuilder]; - let assemblyFormat = "$operand custom(attr-dict) `:` type($res)"; + let assemblyFormat = "$operand attr-dict `:` type($res)"; string llvmInstName = instName; string mlirBuilder = [{ auto op = $_builder.create<$_qualCppClassName>($_location, $operand); diff --git a/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp b/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp index d4f8c4c1faf95..aa01aba546971 100644 --- a/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp +++ b/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp @@ -132,17 +132,6 @@ static auto processFMFAttr(ArrayRef attrs) { return filteredAttrs; } -static ParseResult parseLLVMOpAttrs(OpAsmParser &parser, - NamedAttrList &result) { - return parser.parseOptionalAttrDict(result); -} - -static void printLLVMOpAttrs(OpAsmPrinter &printer, Operation *op, - DictionaryAttr attrs) { - auto filteredAttrs = processFMFAttr(attrs.getValue()); - printer.printOptionalAttrDict(filteredAttrs); -} - /// Verifies `symbol`'s use in `op` to ensure the symbol is a valid and /// fully defined llvm.func. static LogicalResult verifySymbolAttrUse(FlatSymbolRefAttr symbol,