[libc++] Fix CI issues recently introduced by localization changes #116216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldionne
force-pushed
the
review/fix-macos-ci
branch
from
366b049 to
5b58ef0
Compare
ldionne
force-pushed
the
review/fix-macos-ci
branch
from
cd2e52b to
6eaaa72
Compare
|
Merging since this passed CI based on previous runs when this was a draft, and this is currently failing all macOS jobs. |
|
I guess this was merged with a proper commit message but an incorrect title, my bad. |
llvmbot
added
libc++
|
@llvm/pr-subscribers-github-workflow @llvm/pr-subscribers-libcxx Author: Louis Dionne (ldionne) ChangesAfter a recent Github Actions runner policy change 1, the version of Xcode included in This moves the bots to the macos 15 (public preview) image, which contains Xcode 16. Also, adjust an UNSUPPORTED annotation that was incorrectly targeting macos 13.7 Full diff: https://github.com/llvm/llvm-project/pull/116216.diff 2 Files Affected:
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index 2184ddd49537b5..91b929732f2808 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -202,13 +202,13 @@ jobs:
matrix:
include:
- config: generic-cxx03
- os: macos-latest
+ os: macos-15
- config: generic-cxx23
- os: macos-latest
+ os: macos-15
- config: generic-modules
- os: macos-latest
+ os: macos-15
- config: apple-configuration
- os: macos-latest
+ os: macos-15
- config: apple-system
os: macos-13
- config: apple-system-hardened
diff --git a/libcxx/test/std/experimental/simd/simd.class/simd_unary.pass.cpp b/libcxx/test/std/experimental/simd/simd.class/simd_unary.pass.cpp
index 8cc9924a3cdae1..17ecfd3b50d255 100644
--- a/libcxx/test/std/experimental/simd/simd.class/simd_unary.pass.cpp
+++ b/libcxx/test/std/experimental/simd/simd.class/simd_unary.pass.cpp
@@ -12,9 +12,8 @@
// Pass-by-value arguments with alignment greater than register width are not supported.
// XFAIL: target=powerpc{{.*}}-ibm-{{.*}} && (clang-17 || clang-18)
-// FIXME: The following issue occurs on macOS 13.7 with Apple clang 15.0.0:
-// clang: error: unable to execute command: Illegal instruction: 4
-// XFAIL: target=x86_64-apple-macosx13.7
+// This test crashes AppleClang 15 but not later versions.
+// UNSUPPORTED: apple-clang-15
// FIXME: The following issue occurs on Windows to Armv7 Ubuntu Linux:
// Assertion failed: N->getValueType(0) == MVT::v1i1 && "Expected v1i1 type"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a recent Github Actions runner policy change 1, the version of Xcode included in
the macos-14 image went from Xcode 16 to Xcode 15, breaking our build bots.
This moves the bots to the macos 15 (public preview) image, which contains Xcode 16.
Also, adjust an UNSUPPORTED annotation that was incorrectly targeting macos 13.7
when it should have been targeting a version of AppleClang.