From 1a7233b7fb59d218ef0183c74d2b634ba41cf9ce Mon Sep 17 00:00:00 2001 From: Romain Thomas Date: Sat, 16 Nov 2024 10:10:23 +0100 Subject: [PATCH] Fix missing `consumeError` which raise error with asserts enabled --- llvm/lib/DebugInfo/PDB/Native/SymbolCache.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/llvm/lib/DebugInfo/PDB/Native/SymbolCache.cpp b/llvm/lib/DebugInfo/PDB/Native/SymbolCache.cpp index 463b9ebe3cbff..95b95a5bbc509 100644 --- a/llvm/lib/DebugInfo/PDB/Native/SymbolCache.cpp +++ b/llvm/lib/DebugInfo/PDB/Native/SymbolCache.cpp @@ -388,12 +388,16 @@ SymbolCache::findPublicSymbolBySectOffset(uint32_t Sect, uint32_t Offset) { return getSymbolById(Iter->second); auto Publics = Session.getPDBFile().getPDBPublicsStream(); - if (!Publics) + if (!Publics) { + consumeError(Publics.takeError()); return nullptr; + } auto ExpectedSyms = Session.getPDBFile().getPDBSymbolStream(); - if (!ExpectedSyms) + if (!ExpectedSyms) { + consumeError(ExpectedSyms.takeError()); return nullptr; + } BinaryStreamRef SymStream = ExpectedSyms->getSymbolArray().getUnderlyingStream();