Skip to content

Add release note for parallel module creation in LLDB #116857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Add release note for parallel module creation in LLDB #116857

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4dafd39
Add release note for parallel module creation in LLDB
JDevlieghere Nov 19, 2024
ba9ff43
Address Jason's comments
JDevlieghere Nov 19, 2024
095618c
Incorporate David's feedback
JDevlieghere Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions llvm/docs/ReleaseNotes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,8 @@ Changes to LLDB

* A new setting `target.launch-working-dir` can be used to set a persistent cwd that is used by default by `process launch` and `run`.

* LLDB now creates modules in parallel, resulting in an average 2x speedup when launching and attaching.
Copy link
Collaborator

@jasonmolenda jasonmolenda Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to highlight it.

Outside of us, I don't think most people know what "creates modules" is. Maybe "reads binaries". More accurately "scans binary symbol tables", but that's pushing what people would understand again.

I do have a little concern that we've only done this for the attach use-case on Darwin, and for the "load all dependent libraries" use case on all platforms. Someone might attach to a process on linux and see no benefit at all, and be sad.

Copy link
Member Author

@JDevlieghere JDevlieghere Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT of the new wording?

Copy link
Collaborator

@DavidSpickett DavidSpickett Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is this does load in parallel everywhere but you only measured it on Darwin, or has the possibility to do so everywhere but only does so right now on Darwin?

The former I would write as:

  • LLDB can . On Darwin this has resulted in...

Implying that YMMV anywhere else.

The latter:

  • LLDB running on Darwin will now load libraries in parallel when attaching or.... This gives an average 2x speedup.

Copy link
Member Author

@JDevlieghere JDevlieghere Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We load modules in parallel everywhere when launching. We only load modules in parallel when attaching on Darwin (because that happens in our dynamic loader plugin). Linux and other platforms could probably/likely do the same thing, but I haven't looked into it. The improvements are the same regardless of whether the attach or launch.


Changes to BOLT
---------------------------------

Expand Down
Loading