[LLVM] Add environment triple for 'llvm' #117218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuber6
requested review from
AaronBallman,
arsenm,
frobtech,
michaelrj-google,
nickdesaulniers,
nikic and
petrhosek
petrhosek
reviewed
Nov 21, 2024
Summary: The LLVM C library is an in-development environment for running executables on various systems. Similarly how we have `-gnu` to indicate that we are using a GNU toolchain we should support `-llvm` to indicate the LLVM C library. This patch only adds the basic support for the triple and does not do any necessary clang changes to handle compiling with it.
nickdesaulniers
approved these changes
Nov 21, 2024
Member
nickdesaulniers
left a comment
nickdesaulniers
left a comment
There was a problem hiding this comment.
This looks a lot like when the initial musl support was added in 9768b0a.
michaelrj-google
approved these changes
Nov 21, 2024
Contributor
michaelrj-google
left a comment
michaelrj-google
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing this!
SchrodingerZhu
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The LLVM C library is an in-development environment for running
executables on various systems. Similarly how we have
-gnuto indicatethat we are using a GNU toolchain we should support
-llvmto indicatethe LLVM C library. This patch only adds the basic support for the
triple and does not do any necessary clang changes to handle compiling
with it.
Fixes #117251