[Clang] Add Doug Wyatt and myself as maintainers for function effect analysis #117324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sirraide
added
documentation
clang
Member
|
@llvm/pr-subscribers-clang Author: None (Sirraide) ChangesDoug implemented quite literally all of it and has been continuously improving the implementation by handling more language constructs we had initially missed. I spent a lot of time reviewing the implementation of the attributes as well as the analysis pass, so in other words, the two of us are probably best equipped to answer any questions that might arise wrt this part of Clang. @dougsonos I hope you’re fine w/ me nominating you, because I’m familiar w/ the implementation, but not so much realtime processing and its requirements... Also, can you check if I found the right email? Full diff: https://github.com/llvm/llvm-project/pull/117324.diff 1 Files Affected:
diff --git a/clang/Maintainers.rst b/clang/Maintainers.rst
index b601f4da0b3a93..dab33ab7c9aa1c 100644
--- a/clang/Maintainers.rst
+++ b/clang/Maintainers.rst
@@ -176,6 +176,14 @@ Thread Safety Analysis
| aaron.puchert\@sap.com (email), aaronpuchert (GitHub), aaronpuchert (Discourse)
+Function Effect Analysis
+~~~~~~~~~~~~~~~~~~~~~~~~
+| Doug Wyatt
+| dwyatt\@apple.com (email), dougsonos (GitHub), dougsonos (Discourse)
+
+| Sirraide
+| aeternalmail\@gmail.com (email), Sirraide (GitHub), Ætérnal (Discord), Sirraide (Discourse)
+
Tools
-----
These maintainers are responsible for user-facing tools under the Clang
|
Co-authored-by: Aaron Ballman <[email protected]>
Contributor
|
LGTM thanks @Sirraide! |
dougsonos
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doug implemented quite literally all of it and has been continuously improving the implementation by handling more language constructs we had initially missed. I spent a lot of time reviewing the implementation of the attributes as well as the analysis pass, so in other words, the two of us are probably best equipped to answer any questions that might arise wrt this part of Clang.
@dougsonos I hope you’re fine w/ me nominating you, because I’m familiar w/ the implementation, but not so much realtime processing and its requirements... Also, can you check if I found the right email?