[flang][Driver] Add correct libraries to driver #117373
Conversation
A recent commit (23d7a6c) introduced a dependency on libLLVMMC.so which was missed. This should fix the resulting buildbot failures.
llvmbot
added
flang:driver
flang
|
This is a placeholder since I need to double check that this is the problem. I am still in the middle of building and testing that this fix works. |
|
@llvm/pr-subscribers-flang-driver Author: Tarun Prabhu (tarunprabhu) ChangesA recent commit (23d7a6c) introduced a dependency on libLLVMMC.so which was missed. This should fix the resulting buildbot failures. Full diff: https://github.com/llvm/llvm-project/pull/117373.diff 1 Files Affected:
diff --git a/flang/tools/flang-driver/CMakeLists.txt b/flang/tools/flang-driver/CMakeLists.txt
index 9a89a6185a3291..06b61e5951881b 100644
--- a/flang/tools/flang-driver/CMakeLists.txt
+++ b/flang/tools/flang-driver/CMakeLists.txt
@@ -6,6 +6,7 @@ link_directories(${LLVM_LIBRARY_DIR})
set( LLVM_LINK_COMPONENTS
${LLVM_TARGETS_TO_BUILD}
+ MC
Option
Support
TargetParser
|
|
It would be good to document what requires the new dependency. If you need more time, just revert the previous patch. |
I think I can just update the commit message. This definitely fixes the issue. The tests just finished running. |
4 participants
A recent commit (23d7a6c) introduced a dependency on libLLVMMC.so. This is to handle the
-print-supported-cpusoption which usesllvm/MC/SubtargetInfo. It requires libLLVMMC to be linked into the flang-driver which the previous commit did not do. This fixes that issue.