[libc++][test] Fix and refactor exception tests for std::vector #117641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winner245
commented
Nov 25, 2024
| try { // Throw in vector(size_type, const allocator_type&) from allocator | ||
| throwing_allocator<int> alloc(false, true); // throw on copy only | ||
| AllocVec get_alloc(0, alloc); | ||
| } catch (int) { |
Contributor
Author
There was a problem hiding this comment.
This test did not throw.
winner245
commented
Nov 25, 2024
| int a[] = {1, 2}; | ||
| Allocator<int> alloc(false); | ||
| throwing_allocator<int> alloc(false, true); // throw on copy only | ||
| AllocVec vec(cpp17_input_iterator<int*>(a), cpp17_input_iterator<int*>(a + 2), alloc); |
Contributor
Author
There was a problem hiding this comment.
This test did not throw.
winner245
commented
Nov 25, 2024
| int a[] = {1, 2}; | ||
| Allocator<int> alloc(false); | ||
| throwing_allocator<int> alloc(false, true); // throw on copy only | ||
| AllocVec vec(forward_iterator<int*>(a), forward_iterator<int*>(a + 2), alloc); |
Contributor
Author
There was a problem hiding this comment.
This test did not throw.
winner245
commented
Nov 25, 2024
| int throw_after = 1; | ||
| vec.emplace_back(throw_after); | ||
| auto vec2 = vec; | ||
| } catch (int) { |
Contributor
Author
There was a problem hiding this comment.
This test threw in the emplace_back call, not in vector(const vector&).
winner245
commented
Nov 25, 2024
| throwing_t v(throw_after); | ||
| vec.insert(vec.end(), 6, v); | ||
| std::vector<throwing_t, test_allocator<throwing_t> > vec2(std::move(vec), test_allocator<throwing_t>(2)); | ||
| } catch (int) { |
Contributor
Author
There was a problem hiding this comment.
This test did not throw.
winner245
force-pushed
the
fix-vector-exception-tests
branch
3 times, most recently
from
977dd93 to
d8ea0f9
Compare
winner245
force-pushed
the
fix-vector-exception-tests
branch
from
d8ea0f9 to
bf2a0b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing exceptions tests for
vector<T>have several issues: some tests did not throw exceptions at all, making them not useless for exception-safety testing, and some tests did not throw exceptions at the intended points, failing to serve their expected purpose. This PR fixes all those tests. Morever, this PR extracted common classes and utilities into a separate header file, and renamed those classes using more descriptive names.For your convenience, I have added comments on the problematic tests.