[NFC][clang] Fix header comment in llvm/test/MC/AArch64/local-bounds-single-trap.ll #117642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-trap.ll llvm/test/MC/AArch64/local-bounds-single-trap.ll was introduced in https://github.com/llvm/llvm-project/pull/65972/files to demonstrate that nomerge did not work properly, which is documented in the header comment. llvm#101549 fixed nomerge for trap builtins and llvm@ae6dc64 updated the test assertions, but not the header comment. This patch updates the header comment accordingly.
Member
|
@llvm/pr-subscribers-backend-aarch64 @llvm/pr-subscribers-mc Author: Thurston Dang (thurstond) Changesllvm/test/MC/AArch64/local-bounds-single-trap.ll was introduced in #65972 to demonstrate that nomerge did not work properly, which is documented in the header comment. #101549 fixed nomerge for trap builtins and ae6dc64 updated the test assertions, but not the header comment. This patch updates the header comment accordingly. Full diff: https://github.com/llvm/llvm-project/pull/117642.diff 1 Files Affected:
diff --git a/llvm/test/MC/AArch64/local-bounds-single-trap.ll b/llvm/test/MC/AArch64/local-bounds-single-trap.ll
index 6a017e24ab3cdf..8b8a3e430df692 100644
--- a/llvm/test/MC/AArch64/local-bounds-single-trap.ll
+++ b/llvm/test/MC/AArch64/local-bounds-single-trap.ll
@@ -1,7 +1,8 @@
; RUN: llc -O3 -mtriple arm64-linux -filetype asm -o - %s | FileCheck %s -check-prefix CHECK-ASM
-; What this test does is check that even with nomerge, the functions still get merged in
-; compiled code as the ubsantrap call gets lowered to a single instruction: brk.
-
+; This test checks that nomerge correctly prevents the traps from being merged
+; in the compiled code.
+; Prior to ae6dc64ec670891cb15049277e43133d4df7fb4b, this test showed that
+; nomerge did not work correctly.
@B = dso_local global [10 x i8] zeroinitializer, align 1
@B2 = dso_local global [10 x i8] zeroinitializer, align 1
|
ZequanWu
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm/test/MC/AArch64/local-bounds-single-trap.ll was introduced in #65972 to demonstrate that nomerge did not work properly, which is documented in the header comment.
#101549 fixed nomerge for trap builtins and ae6dc64 updated the test assertions, but not the header comment. This patch updates the header comment accordingly.