diff --git a/libcxx/test/std/containers/sequences/vector/common.h b/libcxx/test/std/containers/sequences/vector/common.h index e793ab2a21c1d..cd57b6cc3e723 100644 --- a/libcxx/test/std/containers/sequences/vector/common.h +++ b/libcxx/test/std/containers/sequences/vector/common.h @@ -16,10 +16,41 @@ #include "count_new.h" +struct throwing_t { + int* throw_after_n_ = nullptr; + throwing_t() { throw 0; } + + throwing_t(int& throw_after_n) : throw_after_n_(&throw_after_n) { + if (throw_after_n == 0) + throw 0; + --throw_after_n; + } + + throwing_t(const throwing_t& rhs) : throw_after_n_(rhs.throw_after_n_) { + if (throw_after_n_ == nullptr || *throw_after_n_ == 0) + throw 1; + --*throw_after_n_; + } + + throwing_t& operator=(const throwing_t& rhs) { + throw_after_n_ = rhs.throw_after_n_; + if (throw_after_n_ == nullptr || *throw_after_n_ == 0) + throw 1; + --*throw_after_n_; + return *this; + } + + friend bool operator==(const throwing_t& lhs, const throwing_t& rhs) { + return lhs.throw_after_n_ == rhs.throw_after_n_; + } + friend bool operator!=(const throwing_t& lhs, const throwing_t& rhs) { + return lhs.throw_after_n_ != rhs.throw_after_n_; + } +}; + template struct throwing_allocator { - using value_type = T; - using is_always_equal = std::false_type; + using value_type = T; bool throw_on_copy_ = false; diff --git a/libcxx/test/std/containers/sequences/vector/vector.cons/exceptions.pass.cpp b/libcxx/test/std/containers/sequences/vector/vector.cons/exceptions.pass.cpp index 09355688042f9..679eec2413793 100644 --- a/libcxx/test/std/containers/sequences/vector/vector.cons/exceptions.pass.cpp +++ b/libcxx/test/std/containers/sequences/vector/vector.cons/exceptions.pass.cpp @@ -16,98 +16,13 @@ #include #include +#include "../common.h" #include "count_new.h" #include "test_allocator.h" #include "test_iterators.h" -template -struct Allocator { - using value_type = T; - using is_always_equal = std::false_type; - - template - Allocator(const Allocator&) {} - - Allocator(bool should_throw = true) { - if (should_throw) - throw 0; - } - - T* allocate(std::size_t n) { return std::allocator().allocate(n); } - void deallocate(T* ptr, std::size_t n) { std::allocator().deallocate(ptr, n); } - - template - friend bool operator==(const Allocator&, const Allocator&) { - return true; - } -}; - -struct ThrowingT { - int* throw_after_n_ = nullptr; - ThrowingT() { throw 0; } - - ThrowingT(int& throw_after_n) : throw_after_n_(&throw_after_n) { - if (throw_after_n == 0) - throw 0; - --throw_after_n; - } - - ThrowingT(const ThrowingT& rhs) : throw_after_n_(rhs.throw_after_n_) { - if (throw_after_n_ == nullptr || *throw_after_n_ == 0) - throw 1; - --*throw_after_n_; - } - - ThrowingT& operator=(const ThrowingT& rhs) { - throw_after_n_ = rhs.throw_after_n_; - if (throw_after_n_ == nullptr || *throw_after_n_ == 0) - throw 1; - --*throw_after_n_; - return *this; - } -}; - -template -struct Iterator { - using iterator_category = IterCat; - using difference_type = std::ptrdiff_t; - using value_type = int; - using reference = int&; - using pointer = int*; - - int i_; - Iterator(int i = 0) : i_(i) {} - int& operator*() { - if (i_ == 1) - throw 1; - return i_; - } - - friend bool operator==(const Iterator& lhs, const Iterator& rhs) { return lhs.i_ == rhs.i_; } - - friend bool operator!=(const Iterator& lhs, const Iterator& rhs) { return lhs.i_ != rhs.i_; } - - Iterator& operator++() { - ++i_; - return *this; - } - - Iterator operator++(int) { - auto tmp = *this; - ++i_; - return tmp; - } -}; - -void check_new_delete_called() { - assert(globalMemCounter.new_called == globalMemCounter.delete_called); - assert(globalMemCounter.new_array_called == globalMemCounter.delete_array_called); - assert(globalMemCounter.aligned_new_called == globalMemCounter.aligned_delete_called); - assert(globalMemCounter.aligned_new_array_called == globalMemCounter.aligned_delete_array_called); -} - int main(int, char**) { - using AllocVec = std::vector >; + using AllocVec = std::vector >; try { // vector() AllocVec vec; } catch (int) { @@ -115,7 +30,7 @@ int main(int, char**) { check_new_delete_called(); try { // Throw in vector(size_type) from type - std::vector get_alloc(1); + std::vector get_alloc(1); } catch (int) { } check_new_delete_called(); @@ -123,21 +38,21 @@ int main(int, char**) { #if TEST_STD_VER >= 14 try { // Throw in vector(size_type, value_type) from type int throw_after = 1; - ThrowingT v(throw_after); - std::vector get_alloc(1, v); + throwing_t v(throw_after); + std::vector get_alloc(1, v); } catch (int) { } check_new_delete_called(); try { // Throw in vector(size_type, const allocator_type&) from allocator - Allocator alloc(false); + throwing_allocator alloc(/*throw_on_ctor = */ false, /*throw_on_copy = */ true); AllocVec get_alloc(0, alloc); } catch (int) { } check_new_delete_called(); try { // Throw in vector(size_type, const allocator_type&) from the type - std::vector vec(1, std::allocator()); + std::vector vec(1, std::allocator()); } catch (int) { } check_new_delete_called(); @@ -145,20 +60,22 @@ int main(int, char**) { try { // Throw in vector(size_type, value_type, const allocator_type&) from the type int throw_after = 1; - ThrowingT v(throw_after); - std::vector vec(1, v, std::allocator()); + throwing_t v(throw_after); + std::vector vec(1, v, std::allocator()); } catch (int) { } check_new_delete_called(); try { // Throw in vector(InputIterator, InputIterator) from input iterator - std::vector vec((Iterator()), Iterator(2)); + std::vector vec( + (throwing_iterator()), throwing_iterator(2)); } catch (int) { } check_new_delete_called(); try { // Throw in vector(InputIterator, InputIterator) from forward iterator - std::vector vec((Iterator()), Iterator(2)); + std::vector vec( + (throwing_iterator()), throwing_iterator(2)); } catch (int) { } check_new_delete_called(); @@ -172,39 +89,40 @@ int main(int, char**) { try { // Throw in vector(InputIterator, InputIterator, const allocator_type&) from input iterator std::allocator alloc; - std::vector vec(Iterator(), Iterator(2), alloc); + std::vector vec( + throwing_iterator(), throwing_iterator(2), alloc); } catch (int) { } check_new_delete_called(); try { // Throw in vector(InputIterator, InputIterator, const allocator_type&) from forward iterator std::allocator alloc; - std::vector vec(Iterator(), Iterator(2), alloc); + std::vector vec(throwing_iterator(), + throwing_iterator(2), + alloc); } catch (int) { } check_new_delete_called(); try { // Throw in vector(InputIterator, InputIterator, const allocator_type&) from allocator int a[] = {1, 2}; - Allocator alloc(false); + throwing_allocator alloc(/*throw_on_ctor = */ false, /*throw_on_copy = */ true); AllocVec vec(cpp17_input_iterator(a), cpp17_input_iterator(a + 2), alloc); } catch (int) { - // FIXME: never called. } check_new_delete_called(); try { // Throw in vector(InputIterator, InputIterator, const allocator_type&) from allocator int a[] = {1, 2}; - Allocator alloc(false); + throwing_allocator alloc(/*throw_on_ctor = */ false, /*throw_on_copy = */ true); AllocVec vec(forward_iterator(a), forward_iterator(a + 2), alloc); } catch (int) { - // FIXME: never called. } check_new_delete_called(); try { // Throw in vector(const vector&) from type - std::vector vec; - int throw_after = 0; + std::vector vec; + int throw_after = 1; vec.emplace_back(throw_after); auto vec2 = vec; } catch (int) { @@ -212,20 +130,20 @@ int main(int, char**) { check_new_delete_called(); try { // Throw in vector(const vector&, const allocator_type&) from type - std::vector vec; + std::vector vec; int throw_after = 1; vec.emplace_back(throw_after); - std::vector vec2(vec, std::allocator()); + std::vector vec2(vec, std::allocator()); } catch (int) { } check_new_delete_called(); try { // Throw in vector(vector&&, const allocator_type&) from type during element-wise move - std::vector > vec(test_allocator(1)); + std::vector > vec(test_allocator(1)); int throw_after = 10; - ThrowingT v(throw_after); + throwing_t v(throw_after); vec.insert(vec.end(), 6, v); - std::vector > vec2(std::move(vec), test_allocator(2)); + std::vector > vec2(std::move(vec), test_allocator(2)); } catch (int) { } check_new_delete_called(); @@ -233,14 +151,14 @@ int main(int, char**) { #if TEST_STD_VER >= 11 try { // Throw in vector(initializer_list) from type int throw_after = 1; - std::vector vec({ThrowingT(throw_after)}); + std::vector vec({throwing_t(throw_after)}); } catch (int) { } check_new_delete_called(); try { // Throw in vector(initializer_list, const allocator_type&) constructor from type int throw_after = 1; - std::vector vec({ThrowingT(throw_after)}, std::allocator()); + std::vector vec({throwing_t(throw_after)}, std::allocator()); } catch (int) { } check_new_delete_called();