[NFC][flang] Fix execute_command_line test for odd environments #117714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the execute_command_line tests currently runs `cat` on an invalid file and checks its return value, but since we don't control `cat` or the user's path, the return value might not be reliably stable on a per-platform basis. For example, if `git` is installed on Windows in certain configurations it adds a directory to the path containing a `cat` with a different set of error codes to the default Windows one. This patch changes the test to use the `not` binary built by LLVM for testing purposes, which should always return 1 on any platform regardless of the user's environment.
Member
Author
|
I guess my assumption that the tests are always run at the top of the build directory is incorrect. I'll have to work out how to get the path to the top level build dir. |
The not binary will always be placed in this directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the execute_command_line tests currently runs
caton an invalid file and checks its return value, but since we don't controlcator the user's path, the return value might not be reliably stable on a per-platform basis. For example, ifgitis installed on Windows in certain configurations it adds a directory to the path containing acatwith a different set of error codes to the default Windows one.This patch changes the test to use the
notbinary built by LLVM for testing purposes, which should always return 1 on any platform regardless of the user's environment.