Skip to content

[CGData][GlobalIsel][Legalizer][DAG][MC][AsmParser][X86][AMX] Use std::move to avoid copy #118068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phoebewang merged 7 commits into from
Dec 6, 2024
Merged

[CGData][GlobalIsel][Legalizer][DAG][MC][AsmParser][X86][AMX] Use std::move to avoid copy #118068

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ce16eb4
[CGData][GlobalIsel][Legalizer][DAG][MC][AsmParser][X86][AMX] Use std…
abhishek-kaushik22 Nov 29, 2024
64e844a
Update StableFunctionMap.h
abhishek-kaushik22 Dec 5, 2024
1373979
Merge branch 'main' into move
abhishek-kaushik22 Dec 5, 2024
dbf9c38
Update StableFunctionMap.h
abhishek-kaushik22 Dec 5, 2024
d236864
Merge branch 'move' of https://github.com/abhishek-kaushik22/llvm-pro…
abhishek-kaushik22 Dec 5, 2024
9d4c10f
Update SelectionDAG.cpp
abhishek-kaushik22 Dec 5, 2024
b39ffba
Review Changes
abhishek-kaushik22 Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7717,9 +7717,9 @@ bool CombinerHelper::matchShuffleUndefRHS(MachineInstr &MI,
if (!Changed)
return false;

MatchInfo = [&, NewMask](MachineIRBuilder &B) {
MatchInfo = [&, NewMask = std::move(NewMask)](MachineIRBuilder &B) {
B.buildShuffleVector(MI.getOperand(0), MI.getOperand(1), MI.getOperand(2),
NewMask);
std::move(NewMask));
};

return true;
Expand Down
6 changes: 3 additions & 3 deletions llvm/lib/CodeGen/GlobalISel/LegalityPredicates.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ LegalityPredicates::typeInSet(unsigned TypeIdx,
std::initializer_list<LLT> TypesInit) {
SmallVector<LLT, 4> Types = TypesInit;
return [=](const LegalityQuery &Query) {
return llvm::is_contained(Types, Query.Types[TypeIdx]);
return llvm::is_contained(std::move(Types), Query.Types[TypeIdx]);
};
}

Expand All @@ -45,7 +45,7 @@ LegalityPredicate LegalityPredicates::typePairInSet(
SmallVector<std::pair<LLT, LLT>, 4> Types = TypesInit;
return [=](const LegalityQuery &Query) {
std::pair<LLT, LLT> Match = {Query.Types[TypeIdx0], Query.Types[TypeIdx1]};
return llvm::is_contained(Types, Match);
return llvm::is_contained(std::move(Types), Match);
};
}

Expand All @@ -56,7 +56,7 @@ LegalityPredicate LegalityPredicates::typeTupleInSet(
return [=](const LegalityQuery &Query) {
std::tuple<LLT, LLT, LLT> Match = {
Query.Types[TypeIdx0], Query.Types[TypeIdx1], Query.Types[TypeIdx2]};
return llvm::is_contained(Types, Match);
return llvm::is_contained(std::move(Types), Match);
};
}

Expand Down
4 changes: 2 additions & 2 deletions llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6823,8 +6823,8 @@ SDValue SelectionDAG::FoldConstantArithmetic(unsigned Opcode, const SDLoc &DL,
ScalarOps.push_back(getUNDEF(OpVT));
continue;
}
APInt Val = cast<ConstantSDNode>(Op)->getAPIntValue();
ScalarOps.push_back(SignExtendInReg(Val, OpVT));
const APInt &Val = cast<ConstantSDNode>(Op)->getAPIntValue();
ScalarOps.push_back(SignExtendInReg(std::move(Val), OpVT));
}
return getBuildVector(VT, DL, ScalarOps);
}
Expand Down
2 changes: 1 addition & 1 deletion llvm/lib/MC/MCParser/AsmParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6287,7 +6287,7 @@ bool AsmParser::parseMSInlineAsm(
if (AsmStart != AsmEnd)
OS << StringRef(AsmStart, AsmEnd - AsmStart);

AsmString = AsmStringIR;
AsmString = std::move(AsmStringIR);
return false;
}

Expand Down
40 changes: 20 additions & 20 deletions llvm/lib/MC/MCStreamer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ void MCStreamer::emitCFIStartProc(bool IsSimple, SMLoc Loc) {
}

FrameInfoStack.emplace_back(DwarfFrameInfos.size(), getCurrentSectionOnly());
DwarfFrameInfos.push_back(Frame);
DwarfFrameInfos.push_back(std::move(Frame));
}

void MCStreamer::emitCFIStartProcImpl(MCDwarfFrameInfo &Frame) {
Expand Down Expand Up @@ -510,7 +510,7 @@ void MCStreamer::emitCFIDefCfa(int64_t Register, int64_t Offset, SMLoc Loc) {
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
if (!CurFrame)
return;
CurFrame->Instructions.push_back(Instruction);
CurFrame->Instructions.push_back(std::move(Instruction));
CurFrame->CurrentCfaRegister = static_cast<unsigned>(Register);
}

Expand All @@ -521,7 +521,7 @@ void MCStreamer::emitCFIDefCfaOffset(int64_t Offset, SMLoc Loc) {
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
if (!CurFrame)
return;
CurFrame->Instructions.push_back(Instruction);
CurFrame->Instructions.push_back(std::move(Instruction));
}

void MCStreamer::emitCFIAdjustCfaOffset(int64_t Adjustment, SMLoc Loc) {
Expand All @@ -531,7 +531,7 @@ void MCStreamer::emitCFIAdjustCfaOffset(int64_t Adjustment, SMLoc Loc) {
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
if (!CurFrame)
return;
CurFrame->Instructions.push_back(Instruction);
CurFrame->Instructions.push_back(std::move(Instruction));
}

void MCStreamer::emitCFIDefCfaRegister(int64_t Register, SMLoc Loc) {
Expand All @@ -541,7 +541,7 @@ void MCStreamer::emitCFIDefCfaRegister(int64_t Register, SMLoc Loc) {
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
if (!CurFrame)
return;
CurFrame->Instructions.push_back(Instruction);
CurFrame->Instructions.push_back(std::move(Instruction));
CurFrame->CurrentCfaRegister = static_cast<unsigned>(Register);
}

Expand All @@ -553,7 +553,7 @@ void MCStreamer::emitCFILLVMDefAspaceCfa(int64_t Register, int64_t Offset,
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
if (!CurFrame)
return;
CurFrame->Instructions.push_back(Instruction);
CurFrame->Instructions.push_back(std::move(Instruction));
CurFrame->CurrentCfaRegister = static_cast<unsigned>(Register);
}

Expand All @@ -564,7 +564,7 @@ void MCStreamer::emitCFIOffset(int64_t Register, int64_t Offset, SMLoc Loc) {
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
if (!CurFrame)
return;
CurFrame->Instructions.push_back(Instruction);
CurFrame->Instructions.push_back(std::move(Instruction));
}

void MCStreamer::emitCFIRelOffset(int64_t Register, int64_t Offset, SMLoc Loc) {
Expand All @@ -574,7 +574,7 @@ void MCStreamer::emitCFIRelOffset(int64_t Register, int64_t Offset, SMLoc Loc) {
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
if (!CurFrame)
return;
CurFrame->Instructions.push_back(Instruction);
CurFrame->Instructions.push_back(std::move(Instruction));
}

void MCStreamer::emitCFIPersonality(const MCSymbol *Sym,
Expand All @@ -601,7 +601,7 @@ void MCStreamer::emitCFIRememberState(SMLoc Loc) {
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
if (!CurFrame)
return;
CurFrame->Instructions.push_back(Instruction);
CurFrame->Instructions.push_back(std::move(Instruction));
}

void MCStreamer::emitCFIRestoreState(SMLoc Loc) {
Expand All @@ -612,7 +612,7 @@ void MCStreamer::emitCFIRestoreState(SMLoc Loc) {
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
if (!CurFrame)
return;
CurFrame->Instructions.push_back(Instruction);
CurFrame->Instructions.push_back(std::move(Instruction));
}

void MCStreamer::emitCFISameValue(int64_t Register, SMLoc Loc) {
Expand All @@ -622,7 +622,7 @@ void MCStreamer::emitCFISameValue(int64_t Register, SMLoc Loc) {
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
if (!CurFrame)
return;
CurFrame->Instructions.push_back(Instruction);
CurFrame->Instructions.push_back(std::move(Instruction));
}

void MCStreamer::emitCFIRestore(int64_t Register, SMLoc Loc) {
Expand All @@ -632,7 +632,7 @@ void MCStreamer::emitCFIRestore(int64_t Register, SMLoc Loc) {
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
if (!CurFrame)
return;
CurFrame->Instructions.push_back(Instruction);
CurFrame->Instructions.push_back(std::move(Instruction));
}

void MCStreamer::emitCFIEscape(StringRef Values, SMLoc Loc) {
Expand All @@ -642,7 +642,7 @@ void MCStreamer::emitCFIEscape(StringRef Values, SMLoc Loc) {
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
if (!CurFrame)
return;
CurFrame->Instructions.push_back(Instruction);
CurFrame->Instructions.push_back(std::move(Instruction));
}

void MCStreamer::emitCFIGnuArgsSize(int64_t Size, SMLoc Loc) {
Expand All @@ -652,7 +652,7 @@ void MCStreamer::emitCFIGnuArgsSize(int64_t Size, SMLoc Loc) {
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
if (!CurFrame)
return;
CurFrame->Instructions.push_back(Instruction);
CurFrame->Instructions.push_back(std::move(Instruction));
}

void MCStreamer::emitCFISignalFrame() {
Expand All @@ -669,7 +669,7 @@ void MCStreamer::emitCFIUndefined(int64_t Register, SMLoc Loc) {
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
if (!CurFrame)
return;
CurFrame->Instructions.push_back(Instruction);
CurFrame->Instructions.push_back(std::move(Instruction));
}

void MCStreamer::emitCFIRegister(int64_t Register1, int64_t Register2,
Expand All @@ -680,7 +680,7 @@ void MCStreamer::emitCFIRegister(int64_t Register1, int64_t Register2,
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
if (!CurFrame)
return;
CurFrame->Instructions.push_back(Instruction);
CurFrame->Instructions.push_back(std::move(Instruction));
}

void MCStreamer::emitCFIWindowSave(SMLoc Loc) {
Expand All @@ -689,7 +689,7 @@ void MCStreamer::emitCFIWindowSave(SMLoc Loc) {
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
if (!CurFrame)
return;
CurFrame->Instructions.push_back(Instruction);
CurFrame->Instructions.push_back(std::move(Instruction));
}

void MCStreamer::emitCFINegateRAState(SMLoc Loc) {
Expand All @@ -699,7 +699,7 @@ void MCStreamer::emitCFINegateRAState(SMLoc Loc) {
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
if (!CurFrame)
return;
CurFrame->Instructions.push_back(Instruction);
CurFrame->Instructions.push_back(std::move(Instruction));
}

void MCStreamer::emitCFINegateRAStateWithPC(SMLoc Loc) {
Expand All @@ -709,7 +709,7 @@ void MCStreamer::emitCFINegateRAStateWithPC(SMLoc Loc) {
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
if (!CurFrame)
return;
CurFrame->Instructions.push_back(Instruction);
CurFrame->Instructions.push_back(std::move(Instruction));
}

void MCStreamer::emitCFIReturnColumn(int64_t Register) {
Expand All @@ -733,7 +733,7 @@ void MCStreamer::emitCFIValOffset(int64_t Register, int64_t Offset, SMLoc Loc) {
MCDwarfFrameInfo *CurFrame = getCurrentDwarfFrameInfo();
if (!CurFrame)
return;
CurFrame->Instructions.push_back(Instruction);
CurFrame->Instructions.push_back(std::move(Instruction));
}

WinEH::FrameInfo *MCStreamer::EnsureValidWinFrameInfo(SMLoc Loc) {
Expand Down
6 changes: 3 additions & 3 deletions llvm/lib/Target/X86/X86TileConfig.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ static void collectVirtRegShapes(MachineRegisterInfo *MRI, VirtRegMap &VRM,
unsigned Index = PhysReg - X86::TMM0;
if (!Phys2Shapes[Index].isValid()) {
ShapeT Shape = VRM.getShape(VirtReg);
Phys2Shapes[Index] = Shape;
Phys2Shapes[Index] = std::move(Shape);
return;
}
}
Expand All @@ -118,12 +118,12 @@ static void collectVirtRegShapes(MachineRegisterInfo *MRI, VirtRegMap &VRM,

if (!Phys2Shapes[Index0].isValid()) {
ShapeT Shape0(Shape.getRow(0), Shape.getCol(0), MRI);
Phys2Shapes[Index0] = Shape0;
Phys2Shapes[Index0] = std::move(Shape0);
}

if (!Phys2Shapes[Index1].isValid()) {
ShapeT Shape1(Shape.getRow(1), Shape.getCol(1), MRI);
Phys2Shapes[Index1] = Shape1;
Phys2Shapes[Index1] = std::move(Shape1);
}
}
}
Expand Down
Loading