Fix double-quotes in diagnostic when attempting to access a ext_vector of bools #118186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang Author: William Tran-Viet (smallp-o-p) ChangesFixes #116932 Full diff: https://github.com/llvm/llvm-project/pull/118186.diff 2 Files Affected:
diff --git a/clang/lib/Sema/SemaExprMember.cpp b/clang/lib/Sema/SemaExprMember.cpp
index 434768b99d631e..3d843bb84d9d8b 100644
--- a/clang/lib/Sema/SemaExprMember.cpp
+++ b/clang/lib/Sema/SemaExprMember.cpp
@@ -1655,8 +1655,10 @@ static ExprResult LookupMemberExpr(Sema &S, LookupResult &R,
// We disallow element access for ext_vector_type bool. There is no way to
// materialize a reference to a vector element as a pointer (each element is
// one bit in the vector).
+ assert(MemberName.isIdentifier() &&
+ "Ext vector component name not an identifier!");
S.Diag(R.getNameLoc(), diag::err_ext_vector_component_name_illegal)
- << MemberName
+ << MemberName.getAsIdentifierInfo()->getName()
<< (BaseExpr.get() ? BaseExpr.get()->getSourceRange() : SourceRange());
return ExprError();
}
diff --git a/clang/test/SemaCXX/vector-bool.cpp b/clang/test/SemaCXX/vector-bool.cpp
index e99d420e73fab2..cd638056f348b0 100644
--- a/clang/test/SemaCXX/vector-bool.cpp
+++ b/clang/test/SemaCXX/vector-bool.cpp
@@ -85,10 +85,10 @@ void foo(const bool& X);
// Disallow element-wise access.
bool* ElementRefs() {
- eight_bools.y = false; // expected-error@88 {{illegal vector component name ''y''}}
- &eight_bools.z; // expected-error@89 {{illegal vector component name ''z''}}
- foo(eight_bools.w); // expected-error@90 {{illegal vector component name ''w''}}
- foo(eight_bools.wyx); // expected-error@91 {{illegal vector component name ''wyx''}}
+ eight_bools.y = false; // expected-error@88 {{illegal vector component name 'y'}}
+ &eight_bools.z; // expected-error@89 {{illegal vector component name 'z'}}
+ foo(eight_bools.w); // expected-error@90 {{illegal vector component name 'w'}}
+ foo(eight_bools.wyx); // expected-error@91 {{illegal vector component name 'wyx'}}
}
void Sizeof() {
|
cor3ntin
reviewed
Dec 6, 2024
shafik
reviewed
Dec 6, 2024
Collaborator
shafik
left a comment
shafik
left a comment
There was a problem hiding this comment.
Thank you for your contribution, please add a more detailed summary to your PR. Your summary should if your title describes the problem sufficiently describe how you will fix the problem.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
smallp-o-p
force-pushed
the
116932-Double-single-quotes-in-"illegal-vector-component-name"-diagnostic
branch
from
805195c to
eb073be
Compare
…n CheckExtVector(), and offset the diagnostic arrow so it points to the offending component, rather than the '.' at the start of the component identifier.
smallp-o-p
force-pushed
the
116932-Double-single-quotes-in-"illegal-vector-component-name"-diagnostic
branch
from
eb073be to
1bcf418
Compare
…use a more explicit StringRef constructor
smallp-o-p
force-pushed
the
116932-Double-single-quotes-in-"illegal-vector-component-name"-diagnostic
branch
from
5c135e8 to
ad89f32
Compare
erichkeane
reviewed
Dec 16, 2024
Contributor
|
Do you need someone to push this? |
…or-component-name"-diagnostic
Contributor
Author
|
Yes please. |
smallp-o-p
deleted the
116932-Double-single-quotes-in-"illegal-vector-component-name"-diagnostic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116932
CheckExtVectorComponentOpLocpassed intoS.Diagso the error message arrow points directly to the offending illegal component rather than to the '.' at the start of the component identifier.vector-bool.cppelement-wise access test case so it (correctly) now only expects a single set of quotes.