diff --git a/mlir/lib/Dialect/ArmSME/Transforms/VectorLegalization.cpp b/mlir/lib/Dialect/ArmSME/Transforms/VectorLegalization.cpp index e908a536e6fb2..61767f3b21c9c 100644 --- a/mlir/lib/Dialect/ArmSME/Transforms/VectorLegalization.cpp +++ b/mlir/lib/Dialect/ArmSME/Transforms/VectorLegalization.cpp @@ -265,8 +265,8 @@ struct LegalizeMaskedVectorOuterProductOpsByDecomposition LogicalResult matchAndRewrite(vector::MaskOp maskOp, OpAdaptor adaptor, OneToNPatternRewriter &rewriter) const override { - if (auto outerProductOp = - llvm::dyn_cast(maskOp.getMaskableOp())) { + if (auto outerProductOp = llvm::dyn_cast_or_null( + maskOp.getMaskableOp())) { LegalizeVectorOuterProductOpsByDecomposition pattern(*getTypeConverter(), getContext()); return static_cast(pattern).matchAndRewrite( diff --git a/mlir/test/Dialect/ArmSME/vector-legalization.mlir b/mlir/test/Dialect/ArmSME/vector-legalization.mlir index 458906a187982..d56df9814f173 100644 --- a/mlir/test/Dialect/ArmSME/vector-legalization.mlir +++ b/mlir/test/Dialect/ArmSME/vector-legalization.mlir @@ -646,3 +646,13 @@ func.func @negative_transpose_store_scalable_via_za__bad_source_shape(%vec: vect vector.transfer_write %tr, %dest[%i, %j] {in_bounds = [true, true]} : vector<[7]x2xf32>, memref return } + +// ----- + +// From: https://github.com/llvm/llvm-project/issues/118449. +// Check -arm-sme-vector-legalization does not crash when it encounters a `vector.mask` that +// does not contain a maskable op. +func.func @vector_mask_without_maskable_op(%mask: vector<16x2xi1>, %vec: vector<16x16xf32>) -> vector<16x16xf32> { + %0 = vector.mask %mask { vector.yield %vec : vector<16x16xf32> } : vector<16x2xi1> -> vector<16x16xf32> + return %0 : vector<16x16xf32> +}