[MachineLICM] Fix the check for high register pressure #118780
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should be checking the register pressure change in MI's parent block before hoisting the instruction.
Contributor
Author
|
See #118783 for the test. Once I collect statistics for spec, I'll post it here. |
Contributor
Could you please include the precommit in this patch so we can see how it changed in the diff? |
Contributor
Author
|
Actually I am not sure if this is a right thing to do. I am trying to understand the register pressure check and it just doesn't make sense to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be checking the register pressure change in MI's parent block before hoisting the instruction.