diff --git a/llvm/lib/Transforms/InstCombine/InstCombineShifts.cpp b/llvm/lib/Transforms/InstCombine/InstCombineShifts.cpp index 10c3ccdb2243a..d511e79e3e48a 100644 --- a/llvm/lib/Transforms/InstCombine/InstCombineShifts.cpp +++ b/llvm/lib/Transforms/InstCombine/InstCombineShifts.cpp @@ -427,7 +427,8 @@ Instruction *InstCombinerImpl::commonShiftTransforms(BinaryOperator &I) { if (Instruction *R = FoldOpIntoSelect(I, SI)) return R; - if (Constant *CUI = dyn_cast(Op1)) + Constant *CUI; + if (match(Op1, m_ImmConstant(CUI))) if (Instruction *Res = FoldShiftByConstant(Op0, CUI, I)) return Res; diff --git a/llvm/test/Transforms/InstCombine/shl-twice-constant.ll b/llvm/test/Transforms/InstCombine/shl-twice-constant.ll new file mode 100644 index 0000000000000..bbdd7fa3d1c40 --- /dev/null +++ b/llvm/test/Transforms/InstCombine/shl-twice-constant.ll @@ -0,0 +1,16 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py +; RUN: opt < %s -passes=instcombine -S | FileCheck %s + +@c = external constant i8 +@c2 = external constant i8 + +define i64 @testfunc() { +; CHECK-LABEL: @testfunc( +; CHECK-NEXT: [[SHL1:%.*]] = shl nuw i64 1, ptrtoint (ptr @c2 to i64) +; CHECK-NEXT: [[SHL2:%.*]] = shl i64 [[SHL1]], ptrtoint (ptr @c to i64) +; CHECK-NEXT: ret i64 [[SHL2]] +; + %shl1 = shl i64 1, ptrtoint (ptr @c2 to i64) + %shl2 = shl i64 %shl1, ptrtoint (ptr @c to i64) + ret i64 %shl2 +}