[clangd] Add clarifying comment about when Dex::IdxContents is populated #118906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-clang-tools-extra Author: Nathan Ridge (HighCommander4) ChangesThis is a follow-up to #118324 to document that the Full diff: https://github.com/llvm/llvm-project/pull/118906.diff 1 Files Affected:
diff --git a/clang-tools-extra/clangd/index/dex/Dex.h b/clang-tools-extra/clangd/index/dex/Dex.h
index 69e161d51135b6..8ae4050d004e28 100644
--- a/clang-tools-extra/clangd/index/dex/Dex.h
+++ b/clang-tools-extra/clangd/index/dex/Dex.h
@@ -121,6 +121,8 @@ class Dex : public SymbolIndex {
llvm::DenseMap<std::pair<SymbolID, uint8_t>, std::vector<SymbolID>> Relations;
std::shared_ptr<void> KeepAlive; // poor man's move-only std::any
// Set of files which were used during this index build.
+ // Files and IdxContents are only populated for dynamic and background
+ // indexes, not static indexes.
llvm::StringSet<> Files;
// Contents of the index (symbols, references, etc.)
IndexContents IdxContents;
|
Member
|
@llvm/pr-subscribers-clangd Author: Nathan Ridge (HighCommander4) ChangesThis is a follow-up to #118324 to document that the Full diff: https://github.com/llvm/llvm-project/pull/118906.diff 1 Files Affected:
diff --git a/clang-tools-extra/clangd/index/dex/Dex.h b/clang-tools-extra/clangd/index/dex/Dex.h
index 69e161d51135b6..8ae4050d004e28 100644
--- a/clang-tools-extra/clangd/index/dex/Dex.h
+++ b/clang-tools-extra/clangd/index/dex/Dex.h
@@ -121,6 +121,8 @@ class Dex : public SymbolIndex {
llvm::DenseMap<std::pair<SymbolID, uint8_t>, std::vector<SymbolID>> Relations;
std::shared_ptr<void> KeepAlive; // poor man's move-only std::any
// Set of files which were used during this index build.
+ // Files and IdxContents are only populated for dynamic and background
+ // indexes, not static indexes.
llvm::StringSet<> Files;
// Contents of the index (symbols, references, etc.)
IndexContents IdxContents;
|
kadircet
reviewed
Dec 6, 2024
HighCommander4
force-pushed
the
idxcontents
branch
from
7dcd5e9 to
45311db
Compare
HighCommander4
changed the title
kadircet
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #118324 to document that the
DexfieldsFilesandIdxContentsare intentionally only used in some cases, and describe what those cases are.