[lldb] Improving unit test helpers by utilizing llvm helpers. #119148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was suggested in a previous patch after the commit was already submitted.
Member
|
@llvm/pr-subscribers-lldb Author: John Harrison (ashgti) ChangesThis was suggested in a previous patch after the commit was already submitted. Full diff: https://github.com/llvm/llvm-project/pull/119148.diff 1 Files Affected:
diff --git a/lldb/unittests/TestingSupport/Host/SocketTestUtilities.cpp b/lldb/unittests/TestingSupport/Host/SocketTestUtilities.cpp
index 80545b8c533a03..72ecde845567f7 100644
--- a/lldb/unittests/TestingSupport/Host/SocketTestUtilities.cpp
+++ b/lldb/unittests/TestingSupport/Host/SocketTestUtilities.cpp
@@ -122,10 +122,9 @@ bool lldb_private::HostSupportsLocalhostToIPv4() {
auto addresses = SocketAddress::GetAddressInfo(
"localhost", nullptr, AF_UNSPEC, SOCK_STREAM, IPPROTO_TCP);
- return std::find_if(addresses.begin(), addresses.end(),
- [](SocketAddress &addr) {
- return addr.GetFamily() == AF_INET;
- }) != addresses.end();
+ return llvm::any_of(addresses, [](const SocketAddress &addr) {
+ return addr.GetFamily() == AF_INET;
+ });
}
bool lldb_private::HostSupportsLocalhostToIPv6() {
@@ -134,10 +133,9 @@ bool lldb_private::HostSupportsLocalhostToIPv6() {
auto addresses = SocketAddress::GetAddressInfo(
"localhost", nullptr, AF_UNSPEC, SOCK_STREAM, IPPROTO_TCP);
- return std::find_if(addresses.begin(), addresses.end(),
- [](SocketAddress &addr) {
- return addr.GetFamily() == AF_INET6;
- }) != addresses.end();
+ return llvm::any_of(addresses, [](const SocketAddress &addr) {
+ return addr.GetFamily() == AF_INET6;
+ });
}
llvm::Expected<std::string> lldb_private::GetLocalhostIP() {
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was suggested in a previous patch after the commit was already submitted.
Original suggestion #118673 (comment)