Skip to content

Conversation

@paschalis-mpeis
Copy link
Member

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Dec 13, 2024

@llvm/pr-subscribers-bolt

Author: Paschalis Mpeis (paschalis-mpeis)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/119870.diff

2 Files Affected:

  • (modified) bolt/include/bolt/Passes/PLTCall.h (+1-1)
  • (modified) bolt/include/bolt/Passes/TailDuplication.h (+1-1)
diff --git a/bolt/include/bolt/Passes/PLTCall.h b/bolt/include/bolt/Passes/PLTCall.h
index 09ef96e27293da..9c46f5ddf701cc 100644
--- a/bolt/include/bolt/Passes/PLTCall.h
+++ b/bolt/include/bolt/Passes/PLTCall.h
@@ -26,7 +26,7 @@ class PLTCall : public BinaryFunctionPass {
   explicit PLTCall(const cl::opt<bool> &PrintPass)
       : BinaryFunctionPass(PrintPass) {}
 
-  const char *getName() const override { return "PLT call optimization"; }
+  const char *getName() const override { return "plt-call-optimization"; }
   bool shouldPrint(const BinaryFunction &BF) const override {
     return BinaryFunctionPass::shouldPrint(BF);
   }
diff --git a/bolt/include/bolt/Passes/TailDuplication.h b/bolt/include/bolt/Passes/TailDuplication.h
index a2fcab0720ca27..4a7ec083bc4857 100644
--- a/bolt/include/bolt/Passes/TailDuplication.h
+++ b/bolt/include/bolt/Passes/TailDuplication.h
@@ -143,7 +143,7 @@ class TailDuplication : public BinaryFunctionPass {
 
   explicit TailDuplication() : BinaryFunctionPass(false) {}
 
-  const char *getName() const override { return "tail duplication"; }
+  const char *getName() const override { return "tail-duplication"; }
 
   Error runOnFunctions(BinaryContext &BC) override;
 };

@paschalis-mpeis
Copy link
Member Author

Minor patch to use the same convention on TailDuplication and PLTCall passes.
Also avoids creating filenames with spaces when printing those functions.

Copy link
Contributor

@bgergely0 bgergely0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paschalis-mpeis paschalis-mpeis merged commit 2f33a2c into main Oct 15, 2025
10 checks passed
@paschalis-mpeis paschalis-mpeis deleted the users/paschalis-mpeis/nfc-rename-plt-taildup-getnames branch October 15, 2025 12:53
@paschalis-mpeis
Copy link
Member Author

Thanks Gergely. I forgot about this patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants