[AMDGPU] handling of COPY for wide tuples when v_pk_mov_b32 is used #119966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pravinjagtap
force-pushed
the
pravinjagtap/test-cpy-phys-regs
branch
from
f92bbe7 to
c103e60
Compare
pravinjagtap
commented
Dec 14, 2024
| ; GFX90A-LABEL: name: copy_v1024_to_v1024_fwd | ||
| ; GFX90A: liveins: $vgpr2_vgpr3_vgpr4_vgpr5, $vgpr32 | ||
| ; GFX90A-NEXT: {{ $}} | ||
| ; GFX90A-NEXT: $vgpr0_vgpr1 = V_PK_MOV_B32 8, $vgpr32_vgpr33, 12, $vgpr32_vgpr33, 0, 0, 0, 0, 0, implicit $exec, implicit $vgpr32_vgpr33_vgpr34_vgpr35_vgpr36_vgpr37_vgpr38_vgpr39_vgpr40_vgpr41_vgpr42_vgpr43_vgpr44_vgpr45_vgpr46_vgpr47_vgpr48_vgpr49_vgpr50_vgpr51_vgpr52_vgpr53_vgpr54_vgpr55_vgpr56_vgpr57_vgpr58_vgpr59_vgpr60_vgpr61_vgpr62_vgpr63, implicit-def $vgpr0_vgpr1_vgpr2_vgpr3_vgpr4_vgpr5_vgpr6_vgpr7_vgpr8_vgpr9_vgpr10_vgpr11_vgpr12_vgpr13_vgpr14_vgpr15_vgpr16_vgpr17_vgpr18_vgpr19_vgpr20_vgpr21_vgpr22_vgpr23_vgpr24_vgpr25_vgpr26_vgpr27_vgpr28_vgpr29_vgpr30_vgpr31 |
Author
There was a problem hiding this comment.
While expanding V[0:31] = COPY V[32:63], Src tuple is marked as implicit (for every pair, not just for the first) and Dst tuple is marked as implicit-def (in the first and last).
Everything looks fine here or do we also need to mark Src tuple as implicit-def ?
For other sized tuples, I see the similar thing.
Contributor
There was a problem hiding this comment.
The last instruction is picking up an extra exec use for some reason
Author
There was a problem hiding this comment.
But, we don't have similar bug here right ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.