Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
03f5368
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne Dec 16, 2024
16c7c95
Update ImplicitBoolConversionCheck.h
4m4n-x-B4w4ne Dec 16, 2024
0d6fae8
Create implicit-bool-conversion-check.cpp
4m4n-x-B4w4ne Dec 16, 2024
8f134a3
Merge branch 'main' into main
4m4n-x-B4w4ne Dec 16, 2024
e13bf5a
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne Dec 17, 2024
a480460
Update implicit-bool-conversion-check.cpp
4m4n-x-B4w4ne Dec 17, 2024
5d1e7fc
Update ReleaseNotes.rst
4m4n-x-B4w4ne Dec 18, 2024
391c870
Merge branch 'llvm:main' into main
4m4n-x-B4w4ne Dec 18, 2024
9e83c0d
Update ReleaseNotes.rst
4m4n-x-B4w4ne Dec 18, 2024
4b75aff
Update ReleaseNotes.rst
4m4n-x-B4w4ne Dec 18, 2024
dc67c7f
Update ReleaseNotes.rst
4m4n-x-B4w4ne Dec 18, 2024
c6078dc
Update ReleaseNotes.rst
4m4n-x-B4w4ne Dec 18, 2024
0882713
Update ReleaseNotes.rst
4m4n-x-B4w4ne Dec 18, 2024
d59f000
Update ReleaseNotes.rst
4m4n-x-B4w4ne Dec 18, 2024
4520dd6
Update ReleaseNotes.rst
4m4n-x-B4w4ne Dec 18, 2024
a9376ea
Update ReleaseNotes.rst
4m4n-x-B4w4ne Dec 18, 2024
dc229ca
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne Dec 18, 2024
f6efcaa
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne Dec 18, 2024
ac54d56
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne Dec 18, 2024
74031e5
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne Dec 18, 2024
9b46c09
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne Dec 18, 2024
dd41e29
Update implicit-bool-conversion.rst
4m4n-x-B4w4ne Dec 18, 2024
d0c0593
Update implicit-bool-conversion.rst
4m4n-x-B4w4ne Dec 18, 2024
a56019f
Update implicit-bool-conversion-check.cpp
4m4n-x-B4w4ne Dec 18, 2024
ed6e001
Update ReleaseNotes.rst
4m4n-x-B4w4ne Dec 19, 2024
4900886
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne Dec 19, 2024
e1eaf30
Update ReleaseNotes.rst
4m4n-x-B4w4ne Dec 19, 2024
899683c
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne Dec 20, 2024
414768e
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne Dec 20, 2024
565bef8
Update ReleaseNotes.rst
4m4n-x-B4w4ne Dec 20, 2024
dac44f4
Update implicit-bool-conversion-check.cpp
4m4n-x-B4w4ne Dec 20, 2024
fd1f7dc
[Test]Update implicit-bool-conversion-check.cpp
4m4n-x-B4w4ne Dec 20, 2024
df5e48e
Update implicit-bool-conversion-check.cpp
4m4n-x-B4w4ne Dec 22, 2024
56a4e09
Update implicit-bool-conversion-check.cpp
4m4n-x-B4w4ne Dec 22, 2024
75fe805
Update ReleaseNotes.rst
4m4n-x-B4w4ne Dec 23, 2024
dff9123
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne Dec 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions clang-tools-extra/docs/ReleaseNotes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -319,10 +319,10 @@ Changes in existing checks
diagnostic.

- Improved :doc:`readability-implicit-bool-conversion
<clang-tidy/checks/readability/implicit-bool-conversion>` check
by adding the option `UseUpperCaseLiteralSuffix` to select the
case of the literal suffix in fixes and fixing false positive for implicit
conversion of comparison result in C23.
<clang-tidy/checks/readability/implicit-bool-conversion>`
- `UseUpperCaseLiteralSuffix` : check by adding the option to select the case of the literal suffix in fixes and fixing false positive for implicit conversion of comparison result in C23.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check by adding the options should be common for all three options.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, if I was not clear, check by adding the options should be added once before list of added options.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I have done it in Release Notes .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not necessary to repeat check by adding the option thrice.

Copy link
Contributor Author

@4m4n-x-B4w4ne 4m4n-x-B4w4ne Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its looking good now?

- `CheckConversionsToBool`: Allows enabling or disabling warnings for implicit conversions to `bool` .
- `CheckConversionsFromBool`: Allows enabling or disabling warnings for implicit conversions from `bool`.

- Improved :doc:`readability-redundant-smartptr-get
<clang-tidy/checks/readability/redundant-smartptr-get>` check to
Expand All @@ -332,11 +332,6 @@ Changes in existing checks
<clang-tidy/checks/readability/identifier-naming>` check to
validate ``namespace`` aliases.

-Improved :doc: `readability-implicit-bool-conversion
<clang-tidy/checks/readability/implicit-bool-conversion>`
- `CheckConversionsToBool`: Allows enabling or disabling warnings for implicit conversions to `bool` (default) : true .
- `CheckConversionsFromBool`: Allows enabling or disabling warnings for implicit conversions from `bool` (default) : true.

Removed checks
^^^^^^^^^^^^^^

Expand Down
Loading