-
Notifications
You must be signed in to change notification settings - Fork 15.3k
Added options to readability-implicit-bool-conversion #120087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
03f5368
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne 16c7c95
Update ImplicitBoolConversionCheck.h
4m4n-x-B4w4ne 0d6fae8
Create implicit-bool-conversion-check.cpp
4m4n-x-B4w4ne 8f134a3
Merge branch 'main' into main
4m4n-x-B4w4ne e13bf5a
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne a480460
Update implicit-bool-conversion-check.cpp
4m4n-x-B4w4ne 5d1e7fc
Update ReleaseNotes.rst
4m4n-x-B4w4ne 391c870
Merge branch 'llvm:main' into main
4m4n-x-B4w4ne 9e83c0d
Update ReleaseNotes.rst
4m4n-x-B4w4ne 4b75aff
Update ReleaseNotes.rst
4m4n-x-B4w4ne dc67c7f
Update ReleaseNotes.rst
4m4n-x-B4w4ne c6078dc
Update ReleaseNotes.rst
4m4n-x-B4w4ne 0882713
Update ReleaseNotes.rst
4m4n-x-B4w4ne d59f000
Update ReleaseNotes.rst
4m4n-x-B4w4ne 4520dd6
Update ReleaseNotes.rst
4m4n-x-B4w4ne a9376ea
Update ReleaseNotes.rst
4m4n-x-B4w4ne dc229ca
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne f6efcaa
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne ac54d56
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne 74031e5
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne 9b46c09
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne dd41e29
Update implicit-bool-conversion.rst
4m4n-x-B4w4ne d0c0593
Update implicit-bool-conversion.rst
4m4n-x-B4w4ne a56019f
Update implicit-bool-conversion-check.cpp
4m4n-x-B4w4ne ed6e001
Update ReleaseNotes.rst
4m4n-x-B4w4ne 4900886
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne e1eaf30
Update ReleaseNotes.rst
4m4n-x-B4w4ne 899683c
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne 414768e
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne 565bef8
Update ReleaseNotes.rst
4m4n-x-B4w4ne dac44f4
Update implicit-bool-conversion-check.cpp
4m4n-x-B4w4ne fd1f7dc
[Test]Update implicit-bool-conversion-check.cpp
4m4n-x-B4w4ne df5e48e
Update implicit-bool-conversion-check.cpp
4m4n-x-B4w4ne 56a4e09
Update implicit-bool-conversion-check.cpp
4m4n-x-B4w4ne 75fe805
Update ReleaseNotes.rst
4m4n-x-B4w4ne dff9123
Update ImplicitBoolConversionCheck.cpp
4m4n-x-B4w4ne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check by adding the optionsshould be common for all three options.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, if I was not clear,
check by adding the optionsshould be added once before list of added options.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I have done it in Release Notes .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not necessary to repeat
check by adding the optionthrice.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its looking good now?