Skip to content

[mlir] Add Operation::dumpPrettyPrinted #120117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 18, 2024
Merged

[mlir] Add Operation::dumpPrettyPrinted #120117

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4cbb253
[mlir] Add Operation::dumpPrettyPrinted.
weiweichen Dec 16, 2024
0c87100
Merge branch 'main' of https://github.com/llvm/llvm-project into weiw…
weiweichen Dec 16, 2024
fe13015
Update API according to comment.
weiweichen Dec 16, 2024
a670522
Merge branch 'main' of https://github.com/llvm/llvm-project into weiw…
weiweichen Dec 16, 2024
4504b3c
Use dumpPretty instead because lldb doesn't understand default argume…
weiweichen Dec 17, 2024
27ebd72
Merge branch 'main' of https://github.com/llvm/llvm-project into weiw…
weiweichen Dec 17, 2024
5870e25
Remove extra line.
weiweichen Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mlir/include/mlir/IR/Operation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ class alignas(8) Operation final

void print(raw_ostream &os, const OpPrintingFlags &flags = std::nullopt);
void print(raw_ostream &os, AsmState &state);
void dump();
void dump(bool assumeVerified = false);
Copy link
Contributor

@River707 River707 Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to ensure dump is available, we should mark it with LLVM_DUMP_METHOD. Helps prevent the symbol from being killed off.

Copy link
Collaborator

@lattner lattner Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, please use LLVM_DUMP_METHOD


//===--------------------------------------------------------------------===//
// Operands
Expand Down
7 changes: 5 additions & 2 deletions mlir/lib/IR/AsmPrinter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3980,8 +3980,11 @@ void Operation::print(raw_ostream &os, AsmState &state) {
}
}

void Operation::dump() {
print(llvm::errs(), OpPrintingFlags().useLocalScope());
void Operation::dump(bool assumeVerified) {
OpPrintingFlags flags;
if (assumeVerified)
flags.assumeVerified();
print(llvm::errs(), flags.useLocalScope());
llvm::errs() << "\n";
}

Expand Down
Loading