Skip to content

MIPS: Adding a check for JAL argument in PIC mode to prevent crashing on getExpr #120356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 23, 2024
Merged

MIPS: Adding a check for JAL argument in PIC mode to prevent crashing on getExpr #120356

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b91fcc
Adding a check for JAL argument in PIC mode to prevent crashing on ge…
parsifal-47 Dec 18, 2024
ec12ecd
Addressing review feedback
parsifal-47 Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions llvm/lib/Target/Mips/AsmParser/MipsAsmParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2108,6 +2108,10 @@ bool MipsAsmParser::processInstruction(MCInst &Inst, SMLoc IDLoc,
if ((Opcode == Mips::JAL || Opcode == Mips::JAL_MM) && inPicMode()) {
warnIfNoMacro(IDLoc);

if (!Inst.getOperand(0).isExpr()) {
return Error(IDLoc, "jal needs a symbolic expression in PIC mode");
Copy link
Contributor

@wzssyqa wzssyqa Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gas gives the error message like:

k.s: Assembler messages:
k.s:2: Error: unsupported constant in relocation

I think that we should keep them same.

Copy link
Contributor Author

@parsifal-47 parsifal-47 Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, updated to the same message, thank you!

}

const MCExpr *JalExpr = Inst.getOperand(0).getExpr();

// We can do this expansion if there's only 1 symbol in the argument
Expand Down
Loading