Skip to content

[lldb] Negate is_signed variable for argument isUnsigned in TypeSystemClang.cpp #120794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 23, 2024
Merged

[lldb] Negate is_signed variable for argument isUnsigned in TypeSystemClang.cpp #120794

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5cb9a2
Negate is_signed variable for argument isUnsigned
kuilpd Dec 20, 2024
aebf2bd
Add a test to TestTypeSystemClang
kuilpd Dec 23, 2024
a84f8e4
Change decl argument
kuilpd Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8534,7 +8534,7 @@ clang::EnumConstantDecl *TypeSystemClang::AddEnumerationValueToEnumerationType(
bool is_signed = false;
underlying_type.IsIntegerType(is_signed);

llvm::APSInt value(enum_value_bit_size, is_signed);
llvm::APSInt value(enum_value_bit_size, !is_signed);
value = enum_value;

return AddEnumerationValueToEnumerationType(enum_type, decl, name, value);
Expand Down
10 changes: 10 additions & 0 deletions lldb/unittests/Symbol/TestTypeSystemClang.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,16 @@ TEST_F(TestTypeSystemClang, TestGetEnumIntegerTypeBasicTypes) {
}
}

TEST_F(TestTypeSystemClang, TestEnumerationValueSign) {
CompilerType enum_type = m_ast->CreateEnumerationType(
"my_enum_signed", m_ast->GetTranslationUnitDecl(),
OptionalClangModuleID(), Declaration(),
m_ast->GetBasicType(lldb::eBasicTypeSignedChar), false);
auto *enum_decl = m_ast->AddEnumerationValueToEnumerationType(
enum_type, nullptr, "minus_one", -1, 8);
Copy link
Member

@Michael137 Michael137 Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
auto *enum_decl = m_ast->AddEnumerationValueToEnumerationType(
enum_type, nullptr, "minus_one", -1, 8);
auto *enum_decl = m_ast->AddEnumerationValueToEnumerationType(
enum_type, Declaration(), "minus_one", -1, 8);

EXPECT_TRUE(enum_decl->getInitVal().isSigned());
}

TEST_F(TestTypeSystemClang, TestOwningModule) {
auto holder =
std::make_unique<clang_utils::TypeSystemClangHolder>("module_ast");
Expand Down
Loading