Skip to content

Conversation

@paschalis-mpeis
Copy link
Member

The patch toggles on -remove-symtab, checks compatibility with other flags, and omits sections that are removed by tools like llvm-strip.

The patch toggles on `-remove-symtab`, checks compatibility with other
flags, and omits sections that are removed by tools like `llvm-strip`.
@paschalis-mpeis
Copy link
Member Author

This is a draft patch mostly to assess where we stand in terms of a bolt implementation that does binary stripping. It looks like it's close to what strip tools remove from binaries or am I missing anything substantial here?

@paschalis-mpeis
Copy link
Member Author

This draft PR was meant to be a quick exercise to see how one could support stripping in BOLT.
It turns out the next day this patch was published that can fix stripping for gnu strip:
https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=bbc969306f8d5fb6c7b636e25f6f8e278946ef23

TMU, llvm-strip was fixed and now I assume the same for gnu strip, so probably issues #56738 and duplicate #89336 are now resolved.


Given the stripping tools can now properly handle this, I don't see a need for BOLT to duplicate such functionality.
If that somehow changes, we can re-visit this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants