Skip to content

[AArch64][GlobalISel] Fix legalization for <4 x i1> vector stores. #121185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 6, 2025
Merged

[AArch64][GlobalISel] Fix legalization for <4 x i1> vector stores. #121185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fb685bc
[𝘀𝗽𝗿] initial version
aemerson Dec 27, 2024
3f13932
[𝘀𝗽𝗿] changes to main this commit is based on
aemerson Dec 27, 2024
3efe80b
Fix remark checks in test.
aemerson Dec 27, 2024
c6ef0ad
[𝘀𝗽𝗿] changes introduced through rebase
aemerson Dec 28, 2024
bc2cba7
nop
aemerson Dec 28, 2024
28ed715
[𝘀𝗽𝗿] changes introduced through rebase
aemerson Dec 28, 2024
7549717
Try to fix commit stack
aemerson Dec 28, 2024
3ce9053
[𝘀𝗽𝗿] changes introduced through rebase
aemerson Dec 28, 2024
b9059ff
Rebase
aemerson Dec 28, 2024
be3e397
[𝘀𝗽𝗿] changes introduced through rebase
aemerson Jan 6, 2025
78cfaf0
rebase
aemerson Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4118,10 +4118,7 @@ LegalizerHelper::LegalizeResult LegalizerHelper::lowerStore(GStore &StoreMI) {
unsigned StoreWidth = MemTy.getSizeInBits();
unsigned StoreSizeInBits = 8 * MemTy.getSizeInBytes();

if (StoreWidth != StoreSizeInBits) {
if (SrcTy.isVector())
return UnableToLegalize;

if (StoreWidth != StoreSizeInBits && !SrcTy.isVector()) {
// Promote to a byte-sized store with upper bits zero if not
// storing an integral number of bytes. For example, promote
// TRUNCSTORE:i1 X -> TRUNCSTORE:i8 (and X, 1)
Expand Down
6 changes: 5 additions & 1 deletion llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,11 @@ AArch64LegalizerInfo::AArch64LegalizerInfo(const AArch64Subtarget &ST)
.clampMaxNumElements(0, p0, 2)
.lowerIfMemSizeNotPow2()
// TODO: Use BITCAST for v2i8, v2i16 after G_TRUNC gets sorted out
.bitcastIf(typeInSet(0, {v4s8}),
.bitcastIf(all(typeInSet(0, {v4s8}),
LegalityPredicate([=](const LegalityQuery &Query) {
return Query.Types[0].getSizeInBits() ==
Query.MMODescrs[0].MemoryTy.getSizeInBits();
})),
[=](const LegalityQuery &Query) {
const LLT VecTy = Query.Types[0];
return std::pair(0, LLT::scalar(VecTy.getSizeInBits()));
Expand Down
Loading
Loading