diff --git a/mlir/CMakeLists.txt b/mlir/CMakeLists.txt index 7416e522083b7..a888ac243b044 100644 --- a/mlir/CMakeLists.txt +++ b/mlir/CMakeLists.txt @@ -170,7 +170,7 @@ configure_file( # The pybind11 library can be found (set with -DPYBIND_DIR=...) # The python executable is correct (set with -DPython3_EXECUTABLE=...) # By default, find_package and probing for installed pybind11 is performed. -# Super projects can set MLIR_DISABLE_CONFIGURE_PYTHON_DEV_PACKAGES=ON to +# Super projects can set MLIR_DISABLE_CONFIGURE_PYTHON_DEV_PACKAGES=ON to # disable all package setup and control it themselves. #------------------------------------------------------------------------------- diff --git a/mlir/docs/Bindings/Python.md b/mlir/docs/Bindings/Python.md index a0bd1cac118ba..32df3310d811d 100644 --- a/mlir/docs/Bindings/Python.md +++ b/mlir/docs/Bindings/Python.md @@ -1035,7 +1035,7 @@ class ConstantOp(_ods_ir.OpView): ... ``` -expects `value` to be a `TypedAttr` (e.g., `IntegerAttr` or `FloatAttr`). +expects `value` to be a `TypedAttr` (e.g., `IntegerAttr` or `FloatAttr`). Thus, a natural extension is a builder that accepts a MLIR type and a Python value and instantiates the appropriate `TypedAttr`: ```python @@ -1181,9 +1181,9 @@ make the passes available along with the dialect. Dialect functionality other than IR objects or passes, such as helper functions, can be exposed to Python similarly to attributes and types. C API is expected to exist for this functionality, which can then be wrapped using pybind11 and -`[include/mlir/Bindings/Python/PybindAdaptors.h](https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/Bindings/Python/PybindAdaptors.h)`, +[`include/mlir/Bindings/Python/PybindAdaptors.h`](https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/Bindings/Python/PybindAdaptors.h), or nanobind and -`[include/mlir/Bindings/Python/NanobindAdaptors.h](https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/Bindings/Python/NanobindAdaptors.h)` +[`include/mlir/Bindings/Python/NanobindAdaptors.h`](https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/Bindings/Python/NanobindAdaptors.h) utilities to connect to the rest of Python API. The bindings can be located in a separate module or in the same module as attributes and types, and loaded along with the dialect. diff --git a/mlir/test/python/execution_engine.py b/mlir/test/python/execution_engine.py index 6d3a8db8c24be..0d12c35d96bee 100644 --- a/mlir/test/python/execution_engine.py +++ b/mlir/test/python/execution_engine.py @@ -306,7 +306,7 @@ def callback(a): log(arr) with Context(): - # The module takes a subview of the argument memref, casts it to an unranked memref and + # The module takes a subview of the argument memref, casts it to an unranked memref and # calls the callback with it. module = Module.parse( r"""