Skip to content

Update cloning of the DirectXShaderCompiler repo to not include DXC tests #122178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
llvm-beanz merged 2 commits into from
Jan 16, 2025
Merged

Update cloning of the DirectXShaderCompiler repo to not include DXC tests #122178

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0553e79
Update cloning of the DirectXShaderCompiler repo to not include tests…
bfavela Jan 8, 2025
e5f0ee6
Remove superfluous LLVM_INCLUDE_TESTS define
bfavela Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/tools/dxil-dis/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ ExternalProject_Add(DXC
${GIT_SETTINGS}
SOURCE_DIR ${SOURCE_DIR}
BINARY_DIR ${BINARY_DIR}
CMAKE_ARGS -C ${SOURCE_DIR}/cmake/caches/PredefinedParams.cmake -DLLVM_INCLUDE_TESTS=On
CMAKE_ARGS -C ${SOURCE_DIR}/cmake/caches/PredefinedParams.cmake -DLLVM_INCLUDE_TESTS=On -DLLVM_INCLUDE_TESTS=Off -DCLANG_INCLUDE_TESTS=Off -DHLSL_INCLUDE_TESTS=Off
Copy link
Contributor

@damyanp damyanp Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CMAKE_ARGS -C ${SOURCE_DIR}/cmake/caches/PredefinedParams.cmake -DLLVM_INCLUDE_TESTS=On -DLLVM_INCLUDE_TESTS=Off -DCLANG_INCLUDE_TESTS=Off -DHLSL_INCLUDE_TESTS=Off
CMAKE_ARGS -C ${SOURCE_DIR}/cmake/caches/PredefinedParams.cmake -DLLVM_INCLUDE_TESTS=Off -DCLANG_INCLUDE_TESTS=Off -DHLSL_INCLUDE_TESTS=Off

Copy link
Contributor

@damyanp damyanp Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably we don't need two -DLLVM_INCLUDE_TESTS params?

Copy link
Contributor Author

@bfavela bfavela Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh. I should have caught that. Thanks!

BUILD_COMMAND ${CMAKE_COMMAND} --build ${BINARY_DIR} --target llvm-dis
BUILD_BYPRODUCTS ${BINARY_DIR}/bin/llvm-dis
INSTALL_COMMAND ""
Expand Down
Loading