[analyzer][NFC] Update stale test after #97265 #122272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my patch there, I left a test expectation stale. Tests with `REQUIRES: Z3` never run because no bots check such configurations. Here I'm adjusting the test expectations to meet reality.
steakhal
added
clang
Member
|
@llvm/pr-subscribers-clang Author: Balazs Benics (steakhal) ChangesIn my patch there, I left a test expectation stale. Tests with Here I'm adjusting the test expectations to meet reality. Full diff: https://github.com/llvm/llvm-project/pull/122272.diff 1 Files Affected:
diff --git a/clang/test/Analysis/z3/crosscheck-statistics.c b/clang/test/Analysis/z3/crosscheck-statistics.c
index 7192824c5be31c..8db3df169f246e 100644
--- a/clang/test/Analysis/z3/crosscheck-statistics.c
+++ b/clang/test/Analysis/z3/crosscheck-statistics.c
@@ -28,6 +28,6 @@ int rejecting(int n, int x) {
// CHECK-NEXT: 1 BugReporter - Number of reports passed Z3
// CHECK-NEXT: 1 BugReporter - Number of reports refuted by Z3
-// CHECK: 1 Z3CrosscheckVisitor - Number of Z3 queries accepting a report
-// CHECK-NEXT: 1 Z3CrosscheckVisitor - Number of Z3 queries rejecting a report
-// CHECK-NEXT: 2 Z3CrosscheckVisitor - Number of Z3 queries done
+// CHECK: 1 Z3CrosscheckOracle - Number of Z3 queries accepting a report
+// CHECK-NEXT: 1 Z3CrosscheckOracle - Number of Z3 queries rejecting a report
+// CHECK-NEXT: 2 Z3CrosscheckOracle - Number of Z3 queries done
|
Member
|
@llvm/pr-subscribers-clang-static-analyzer-1 Author: Balazs Benics (steakhal) ChangesIn my patch there, I left a test expectation stale. Tests with Here I'm adjusting the test expectations to meet reality. Full diff: https://github.com/llvm/llvm-project/pull/122272.diff 1 Files Affected:
diff --git a/clang/test/Analysis/z3/crosscheck-statistics.c b/clang/test/Analysis/z3/crosscheck-statistics.c
index 7192824c5be31c..8db3df169f246e 100644
--- a/clang/test/Analysis/z3/crosscheck-statistics.c
+++ b/clang/test/Analysis/z3/crosscheck-statistics.c
@@ -28,6 +28,6 @@ int rejecting(int n, int x) {
// CHECK-NEXT: 1 BugReporter - Number of reports passed Z3
// CHECK-NEXT: 1 BugReporter - Number of reports refuted by Z3
-// CHECK: 1 Z3CrosscheckVisitor - Number of Z3 queries accepting a report
-// CHECK-NEXT: 1 Z3CrosscheckVisitor - Number of Z3 queries rejecting a report
-// CHECK-NEXT: 2 Z3CrosscheckVisitor - Number of Z3 queries done
+// CHECK: 1 Z3CrosscheckOracle - Number of Z3 queries accepting a report
+// CHECK-NEXT: 1 Z3CrosscheckOracle - Number of Z3 queries rejecting a report
+// CHECK-NEXT: 2 Z3CrosscheckOracle - Number of Z3 queries done
|
NagyDonat
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my patch there, I left a test expectation stale. Tests with
REQUIRES: Z3never run because no bots check such configurations.Here I'm adjusting the test expectations to meet reality.