From 2a09266473152d9b70af376c69f4c12fd20bcee6 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 9 Jan 2025 22:42:16 +0800 Subject: [PATCH] [clang-tidy][NFC] clean readability-use-std-min-max 1. add `static` for internal linkage functions 2. remove `clang` prefix for `QualType` --- .../readability/UseStdMinMaxCheck.cpp | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/clang-tools-extra/clang-tidy/readability/UseStdMinMaxCheck.cpp b/clang-tools-extra/clang-tidy/readability/UseStdMinMaxCheck.cpp index 9c5c2f3939c99..179173502a8d0 100644 --- a/clang-tools-extra/clang-tidy/readability/UseStdMinMaxCheck.cpp +++ b/clang-tools-extra/clang-tidy/readability/UseStdMinMaxCheck.cpp @@ -59,7 +59,7 @@ static bool maxCondition(const BinaryOperator::Opcode Op, const Expr *CondLhs, return false; } -QualType getNonTemplateAlias(QualType QT) { +static QualType getNonTemplateAlias(QualType QT) { while (true) { // cast to a TypedefType if (const TypedefType *TT = dyn_cast(QT)) { @@ -92,15 +92,15 @@ static std::string createReplacement(const Expr *CondLhs, const Expr *CondRhs, const llvm::StringRef AssignLhsStr = Lexer::getSourceText( Source.getExpansionRange(AssignLhs->getSourceRange()), Source, LO); - clang::QualType GlobalImplicitCastType; - clang::QualType LhsType = CondLhs->getType() - .getCanonicalType() - .getNonReferenceType() - .getUnqualifiedType(); - clang::QualType RhsType = CondRhs->getType() - .getCanonicalType() - .getNonReferenceType() - .getUnqualifiedType(); + QualType GlobalImplicitCastType; + QualType LhsType = CondLhs->getType() + .getCanonicalType() + .getNonReferenceType() + .getUnqualifiedType(); + QualType RhsType = CondRhs->getType() + .getCanonicalType() + .getNonReferenceType() + .getUnqualifiedType(); if (LhsType != RhsType) { GlobalImplicitCastType = getNonTemplateAlias(BO->getLHS()->getType()); }