From 4206d20d3d9c3b30c568be02f5df52632b4152de Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Fri, 10 Jan 2025 01:10:47 +0100 Subject: [PATCH] [libc++] Disable _LIBCPP_NODEBUG temporarily This should be reverted once the crash reported in #118710 has been analyzed. --- libcxx/include/__config | 4 +++- libcxx/test/tools/clang_tidy_checks/libcpp_module.cpp | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libcxx/include/__config b/libcxx/include/__config index ace6e1cd73e3e..2de4c009b5afd 100644 --- a/libcxx/include/__config +++ b/libcxx/include/__config @@ -1170,7 +1170,9 @@ typedef __char32_t char32_t; # define _LIBCPP_NOESCAPE # endif -# define _LIBCPP_NODEBUG [[__gnu__::__nodebug__]] +// FIXME: Expand this to [[__gnu__::__nodebug__]] again once the testcase reported in +// https://github.com/llvm/llvm-project/pull/118710 has been analyzed +# define _LIBCPP_NODEBUG # if __has_attribute(__standalone_debug__) # define _LIBCPP_STANDALONE_DEBUG __attribute__((__standalone_debug__)) diff --git a/libcxx/test/tools/clang_tidy_checks/libcpp_module.cpp b/libcxx/test/tools/clang_tidy_checks/libcpp_module.cpp index bc7c8ce7ec443..f49f3e3c615ca 100644 --- a/libcxx/test/tools/clang_tidy_checks/libcpp_module.cpp +++ b/libcxx/test/tools/clang_tidy_checks/libcpp_module.cpp @@ -27,7 +27,7 @@ class LibcxxTestModule : public clang::tidy::ClangTidyModule { check_factories.registerCheck("libcpp-header-exportable-declarations"); check_factories.registerCheck("libcpp-hide-from-abi"); check_factories.registerCheck("libcpp-internal-ftms"); - check_factories.registerCheck("libcpp-nodebug-on-aliases"); + // check_factories.registerCheck("libcpp-nodebug-on-aliases"); check_factories.registerCheck("libcpp-cpp-version-check"); check_factories.registerCheck("libcpp-robust-against-adl"); check_factories.registerCheck("libcpp-uglify-attributes");