Simplify MSVC compatible compiler detection. #122914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMAKE_CXX_SIMULATE_ID indicates the MSCV abi is usable. Change-Id: I6112f7282400c45b140c44c3f46ac7ea8f97c9ee
mstorsjo
approved these changes
Jan 15, 2025
Member
mstorsjo
left a comment
mstorsjo
left a comment
There was a problem hiding this comment.
LGTM, thanks!
There's a typo in the commit message and PR body, s/MSCV/MSVC/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_CXX_SIMULATE_ID indicates the MSVC abi is usable.