Skip to content

Conversation

@frasercrmck
Copy link
Contributor

Missing half variants were also added.

The builtins are now consistently emitted in vector form (i.e., with a splat of the literal to the appropriate vector size).

Missing half variants were also added.

The builtins are now consistently emitted in vector form (i.e., with a
splat of the literal to the appropriate vector size).
@frasercrmck frasercrmck added the libclc libclc OpenCL library label Jan 16, 2025
@frasercrmck frasercrmck requested a review from arsenm January 16, 2025 17:12
@frasercrmck
Copy link
Contributor Author

I wasn't able to verify the half variants with the OpenCL CTS for some obscure CTS reason. Given that they're just casting the double literal to half I think they're almost certainly correct.

@frasercrmck frasercrmck merged commit a90b5b1 into llvm:main Jan 17, 2025
10 checks passed
@frasercrmck frasercrmck deleted the libclc-clc-radians-degrees branch January 17, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libclc libclc OpenCL library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants